From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5AC18640; Tue, 19 Dec 2023 12:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 01BCC68BFE; Tue, 19 Dec 2023 13:16:49 +0100 (CET) Date: Tue, 19 Dec 2023 13:16:49 +0100 From: "hch@lst.de" To: Damien Le Moal Cc: Ed Tsai =?utf-8?B?KOiUoeWul+i7kik=?= , "Naohiro.Aota@wdc.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "hch@lst.de" , "martin.petersen@oracle.com" , "axboe@kernel.dk" , Chun-Hung Wu =?utf-8?B?KOW3q+mnv+Wujyk=?= , "linux-scsi@vger.kernel.org" , "dm-devel@lists.linux.dev" , "linux-nvme@lists.infradead.org" , "pbonzini@redhat.com" , "linux-btrfs@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "stefanha@redhat.com" Subject: Re: [PATCH 3/5] block: remove support for the host aware zone model Message-ID: <20231219121649.GA21736@lst.de> References: <20231217165359.604246-1-hch@lst.de> <20231217165359.604246-4-hch@lst.de> <190f58f7-2ed6-46f8-af59-5e167a0bddeb@kernel.org> <0a329050-0010-47cb-8c7b-a2f0863a21e8@kernel.org> <20231219103825.GB14379@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219103825.GB14379@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Dec 19, 2023 at 11:38:25AM +0100, hch@lst.de wrote: > > > It's very minor, so is okay to ignore my preference. > > > > Send a patch on top of Christoph's series if you want to clean this up. > > I'll need to respin anyway, so I'll look into incorporating the > suggestion. I did look into it and the iterate callbacks confuse the heck out of me. So I'm not going to touch them in non-trivial ways here and will leave it for follow on cleanups as needed.