From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 449DC374E7; Tue, 19 Dec 2023 17:12:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SvjrK4lPFz6K9KR; Wed, 20 Dec 2023 01:10:41 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 83AA7140F7F; Wed, 20 Dec 2023 01:12:25 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Dec 2023 17:12:11 +0000 Date: Tue, 19 Dec 2023 17:12:10 +0000 From: Jonathan Cameron To: Ira Weiny CC: Smita Koralahalli , Dan Williams , Shiju Jose , "Yazen Ghannam" , Davidlohr Bueso , "Dave Jiang" , Alison Schofield , Vishal Verma , "Ard Biesheuvel" , , , Subject: Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events Message-ID: <20231219171210.000078a6@Huawei.com> In-Reply-To: <657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch> References: <20230601-cxl-cper-v4-0-47bb901f135e@intel.com> <20230601-cxl-cper-v4-5-47bb901f135e@intel.com> <7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com> <65674a71ef4d0_a1b25294e4@iweiny-mobl.notmuch> <20231213171351.00004579@Huawei.com> <657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 13 Dec 2023 14:28:03 -0800 Ira Weiny wrote: > Jonathan Cameron wrote: > > On Wed, 29 Nov 2023 06:28:01 -0800 > > Ira Weiny wrote: > > > > [snip] > > > > > __packed attribute just for cper_cxl_event_rec still fails to properly > > > > align structure elements. Looks like, __packed attribute is needed for > > > > all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside > > > > cper_cxl_event_rec. > > > > > > > > Seems easier to use global pragma instead.. I could test and obtain the > > > > output as expected using pragma.. > > > > > > I did not know that was acceptable in the kernel but I see you used it in > > > cper_cxl.h before... > > > > > > Ok I'll do that and spin again. > > > > > > Thanks so much for testing this! I was out last week and still don't have > > > a test environment. > > > > Easy to hack into QEMU :) Hmm. I have a CCIX patch set from years ago > > somewhere that does similar. Would be easy to repurposed. Looks like > > I never published them (just told people to ask if they wanted them :( ). > > > > Anyhow, if useful I can dig them out. > > If you have a branch with them with a somewhat latest qemu that could work > too. They are ancient and based on GHES emulation that got reworked before being merged. I had a quick go at a forwards port but this is a bigger job than I expected. May be a little while :( Jonathan > > Ira