Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events

Ira Weiny
2023-12-13T22:28:16Z

Jonathan Cameron wrote:
> On Wed, 29 Nov 2023 06:28:01 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
>

[snip]

> > > __packed attribute just for cper_cxl_event_rec still fails to properly
> > > align structure elements. Looks like, __packed attribute is needed for
> > > all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside
> > > cper_cxl_event_rec.
> > >
> > > Seems easier to use global pragma instead.. I could test and obtain the
> > > output as expected using pragma..
> >
> > I did not know that was acceptable in the kernel but I see you used it in
> > cper_cxl.h before...
> >
> > Ok I'll do that and spin again.
> >
> > Thanks so much for testing this! I was out last week and still don't have
> > a test environment.
>
> Easy to hack into QEMU :) Hmm. I have a CCIX patch set from years ago
> somewhere that does similar. Would be easy to repurposed. Looks like
> I never published them (just told people to ask if they wanted them :( ).
>
> Anyhow, if useful I can dig them out.

If you have a branch with them with a somewhat latest qemu that could work
too.

Ira