Re: [PATCH v7 17/23] sched: Initial sched_football test implementation

John Stultz
2024-01-05T05:25:19Z

On Thu, Dec 28, 2023 at 8:36 AM Metin Kaya <metin.kaya@arm.com> wrote:
> On 20/12/2023 12:18 am, John Stultz wrote:
> > +int crazy_fan_thread(void *)
> > +{
> > + int count = 0;
> > +
> > + atomic_inc(&players_ready);
> > + while (!READ_ONCE(game_over)) {
> > + if (kthread_should_stop())
> > + break;
> > + schedule();
> > + udelay(1000);
> > + msleep(2);
> > + count++;
>
> @count is only increased. Is it really necessary?

Nope. Just remnants of earlier debug code.

>
> * Please prepend a prefix to prints to ease capturing the module logs.

Done.

> * I think `rmmod test_sched_football` throws `Device or resource busy`
> error and fails to remove the module because of missing module_exit().

Yep. I'm skipping this for now, but I'll see about adding it later
after I figure out the changes I need to manufacture the problematic
load-balancing condition I'm worried about, as it doesn't seem to
appear on its own so far.

thanks
-john