From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C84E73188; Thu, 21 Dec 2023 13:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VByLrBbg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB4B9C433C7; Thu, 21 Dec 2023 13:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1703164223; bh=+CCOLFjUWuo0kMo+F94tzNDUXNANIfRX23p7wOIacn4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VByLrBbg8keQB7qy7zRDT869faoZCf4CXilzHPdPd56zll+1QysujiZ5IOsTESxUQ cOppswM6obNmC47w8tcBRtFR5C7VhRHDYgdnImQW/uiWgcLrm7K6bxM9MDWfG7AmUr RG5tBSofVHCKkQa1KCOcwZXdcgufaUb5mYfbvTjg= Date: Thu, 21 Dec 2023 14:10:20 +0100 From: Greg Kroah-Hartman To: Hans de Goede Cc: linux-kernel@vger.kernel.org, Maximilian Luz , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform/surface: aggregator: make ssam_bus_type constant and static Message-ID: <2023122109-winking-stature-a487@gregkh> References: <2023121957-tapered-upswing-8326@gregkh> <7f763191-2148-42ad-b1ce-afd1a6d478ff@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f763191-2148-42ad-b1ce-afd1a6d478ff@redhat.com> On Thu, Dec 21, 2023 at 02:03:03PM +0100, Hans de Goede wrote: > Hi Greg, > > On 12/19/23 18:18, Greg Kroah-Hartman wrote: > > Now that the driver core can properly handle constant struct bus_type, > > move the ssam_bus_type variable to be a constant structure as well, > > placing it into read-only memory which can not be modified at runtime. > > > > It's also never used outside of > > drivers/platform/surface/aggregator/bus.c so make it static and don't > > export it as no one is using it. > > > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: "Ilpo Järvinen" > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > Greg, do you plan to merge this yourself (fine with me) > or do you want me to merge this through pdx86 ? I can merge it, thanks! greg k-h