From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE8B31773B for ; Thu, 21 Dec 2023 08:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="quDhBRDL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF5B3C433C8; Thu, 21 Dec 2023 08:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1703148414; bh=y1FNTAj8Bh/ZM8ACZhw9sMqYhwCvI+GD9lAYIihPqSs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=quDhBRDLlEnQK02arNaJ4xhU8o1T3meTTZ4uW3AJtFCqPgmEDRgPekTxR0IKGOpm/ 35UfE+LIM9Zaq4CELnRLqMTxW+p9kFhAH6jxopyzZR2rd9DIthUo7gAsKrQhx+6a4v EaEL/qUGCDQ31G8CrDn/xiGNcoNKkZxH0AU9jVAA= Date: Thu, 21 Dec 2023 09:46:51 +0100 From: Greg Kroah-Hartman To: "Gangurde, Abhijit" Cc: "Gupta, Nipun" , "Agarwal, Nikhil" , "linux-kernel@vger.kernel.org" , Rob Herring Subject: Re: [PATCH 1/2] cdx: Enable COMPILE_TEST Message-ID: <2023122142-blandness-cortex-76c7@gregkh> References: <20231207163128.2707993-1-robh@kernel.org> <2023121551-uncommon-negation-fdda@gregkh> <2023121509-snuggle-lagged-1365@gregkh> <2023122142-huff-closure-d5d4@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 21, 2023 at 08:40:05AM +0000, Gangurde, Abhijit wrote: > > > > > On Thu, Dec 07, 2023 at 10:31:26AM -0600, Rob Herring wrote: > > > > > > There is no reason CDX needs to depend on ARM64 other than limiting > > > > > > visibility. So let's also enable building with COMPILE_TEST. > > > > > > > > > > > > The CONFIG_OF dependency is redundant as ARM64 always enables it > > and > > > > all > > > > > > the DT functions have empty stubs. > > > > > > > > > > > > Signed-off-by: Rob Herring > > > > > > --- > > > > > > drivers/cdx/Kconfig | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig > > > > > > index a08958485e31..7cdb7c414453 100644 > > > > > > --- a/drivers/cdx/Kconfig > > > > > > +++ b/drivers/cdx/Kconfig > > > > > > @@ -7,7 +7,7 @@ > > > > > > > > > > > > config CDX_BUS > > > > > > bool "CDX Bus driver" > > > > > > - depends on OF && ARM64 > > > > > > + depends on ARM64 || COMPILE_TEST > > > > > > > > > > Ok, good start, now we need to turn this into a module, what's keeping > > > > > it from being able to be built as a tristate? > > > > > > > > To answer my own question, the following errors: > > > > > > > > ERROR: modpost: missing MODULE_LICENSE() in drivers/cdx/cdx.o > > > > ERROR: modpost: "iommu_device_unuse_default_domain" > > > > [drivers/cdx/cdx.ko] undefined! > > > > ERROR: modpost: "iommu_device_use_default_domain" > > [drivers/cdx/cdx.ko] > > > > undefined! > > > > > > > > Would be great for someone to fix this up... > > > > > > I did look at this code. There are 2 issues here for it to be a module. > > > 1. There are many symbols in iommu, msi and other module which are not > > exported. > > > Most of other busses like amba, fslmc, pci are bool only. > > > > I only see 2 symbols here, what other ones do you see? > > There are ~5 symbols from cdx msi patch That hasn't been merged yet :)