From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, rajvi.jingar@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/8] Intel PMC Core GBE LTR regression fix
Date: Fri, 22 Dec 2023 19:25:40 -0800 [thread overview]
Message-ID: <20231223032548.1680738-1-david.e.box@linux.intel.com> (raw)
This patch series addresses the network performance regression caused by
commit 804951203aa5 ("platform/x86:intel/pmc: Combine core_init() and
core_configure()").
Unfortunately, the regression is included in the recent Lunar Lake and
Arrow Lake support patches in the review branch. Patches 1 and 2 remove the
LTR ignore without a fix. They may be folded into the respective enabling
patches indicated in the changelog. This is done so that the next patches
fixing the regression can be backported to stable kernels with fewer, if
any, conflicts.
Patches 3 and 4 provide the support needed for Patch 5 to move the GBE LTR
ignore from probe-time to suspend/resume time. All three carry the same
Fixes tag so that the stable kernels can pick them up without causing a
separate suspend-time PC10 regression.
Patches 6 and 7 then add the LTR suspend/resume fix for Arrow Lake and
Lunar Lake. Of course, they cannot be folded into the enabling patches
unless the LTR fixes (3-5) are applied before. Sorry about this :(.
Patch 8 finally addresses an unrelated sparse warning for a missing extern
introduced in the commit mentioned in that changelog. This could be folded
back into that commit if desired.
Note that there is no current solution to address the loss of runtime PC10
with these patches. With a network cable attached to the PCH LAN, the best
that can be achieved is PC8/9. However, this is unlikely to affect many
mobile systems which tend not to use LAN and if they do, not the PCH LAN.
David E. Box (8):
platform/x86/intel/pmc/arl.c: Remove probe time LTR ignore
platform/x86/intel/pmc/lnl.c: Remove probe time LTR ignore
platform/x86/intel/pmc: Add suspend callback
platform/x86/intel/pmc: Allow renabling LTRs
platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback
platform/x86/intel/pmc/arl: Add GBE LTR ignore during suspend
platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend
platform/x86/intel/pmc: Add missing extern
drivers/platform/x86/intel/pmc/adl.c | 9 +++------
drivers/platform/x86/intel/pmc/arl.c | 9 +++------
drivers/platform/x86/intel/pmc/cnp.c | 26 ++++++++++++++++++++------
drivers/platform/x86/intel/pmc/core.c | 12 +++++++++---
drivers/platform/x86/intel/pmc/core.h | 9 ++++++++-
drivers/platform/x86/intel/pmc/lnl.c | 9 +++------
drivers/platform/x86/intel/pmc/mtl.c | 9 +++------
drivers/platform/x86/intel/pmc/tgl.c | 8 +++-----
8 files changed, 52 insertions(+), 39 deletions(-)
base-commit: 119652b855e6c96676406ee9a7f535f4db4e8eff
--
2.34.1
next reply other threads:[~2023-12-23 3:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 3:25 David E. Box [this message]
2023-12-23 3:25 ` [PATCH 1/8] platform/x86/intel/pmc/arl.c: Remove probe time LTR ignore David E. Box
2023-12-23 3:25 ` [PATCH 2/8] platform/x86/intel/pmc/lnl.c: " David E. Box
2023-12-23 3:25 ` [PATCH 3/8] platform/x86/intel/pmc: Add suspend callback David E. Box
2023-12-23 3:25 ` [PATCH 4/8] platform/x86/intel/pmc: Allow reenabling LTRs David E. Box
2023-12-27 17:54 ` Ilpo Järvinen
2023-12-28 15:43 ` Ilpo Järvinen
2023-12-23 3:25 ` [PATCH 5/8] platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback David E. Box
2023-12-23 3:25 ` [PATCH 6/8] platform/x86/intel/pmc/arl: Add GBE LTR ignore during suspend David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-23 3:25 ` [PATCH 7/8] platform/x86/intel/pmc/lnl: " David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-23 3:25 ` [PATCH 8/8] platform/x86/intel/pmc: Add missing extern David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-27 18:14 ` [PATCH 0/8] Intel PMC Core GBE LTR regression fix Ilpo Järvinen
2023-12-28 9:35 ` Hans de Goede
2023-12-28 15:38 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231223032548.1680738-1-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox