From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3BFB1EB37; Mon, 25 Dec 2023 23:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K7QWOIU8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703547076; x=1735083076; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5SMN0AzloiLbP8beEL+tP2MzpuhkZtwKpAax1CA2Udg=; b=K7QWOIU8s9nmwIKUadWNG9iuxqcFRhiLzuX9U9WmVwTG4rm27NZuyLYz JLmv0LUARDgIFvp/dCQfYaX829PKpAwPhbgHjSsR0u1sB3uAKK2FibV1h Cutey/3mFmzn7+hcY20oNylUSJzobIoiicivZ6MA7WFI5L5IeCt8LN785 P4Ldro1l4FFpNJfb+rs95RxoCUj00TygqMmiW8zW6xChW3A5mzJsPuUp6 hyDbZL/Q3RcUDGLn9MFdmalltVtmTPeKcyloYVYrwJaNwDY2jKml4u3qP ul5qY3oBoMdzuZaz7u71nZC2vflQWiiwSb4P/1/qcmbUpTaz3EljQvbLk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="9838291" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="9838291" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 15:31:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="771030390" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="771030390" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga007.jf.intel.com with ESMTP; 25 Dec 2023 15:31:09 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rHuPa-000DmL-2L; Mon, 25 Dec 2023 23:31:06 +0000 Date: Tue, 26 Dec 2023 07:30:55 +0800 From: kernel test robot To: Lino Sanfilippo , gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: Re: [PATCH v6 6/7] serial: omap: do not override settings for RS485 support Message-ID: <202312260719.mI12i497-lkp@intel.com> References: <20231225113524.8800-7-l.sanfilippo@kunbus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231225113524.8800-7-l.sanfilippo@kunbus.com> Hi Lino, kernel test robot noticed the following build errors: [auto build test ERROR on ceb6a6f023fd3e8b07761ed900352ef574010bcb] url: https://github.com/intel-lab-lkp/linux/commits/Lino-Sanfilippo/serial-Do-not-hold-the-port-lock-when-setting-rx-during-tx-GPIO/20231225-193833 base: ceb6a6f023fd3e8b07761ed900352ef574010bcb patch link: https://lore.kernel.org/r/20231225113524.8800-7-l.sanfilippo%40kunbus.com patch subject: [PATCH v6 6/7] serial: omap: do not override settings for RS485 support config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20231226/202312260719.mI12i497-lkp@intel.com/config) compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project d3ef86708241a3bee902615c190dead1638c4e09) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231226/202312260719.mI12i497-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312260719.mI12i497-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/tty/serial/omap-serial.c:1501:29: error: use of undeclared identifier 'serial_omap_rs485_supported' 1501 | up->port.rs485_supported = serial_omap_rs485_supported; | ^ 1 error generated. vim +/serial_omap_rs485_supported +1501 drivers/tty/serial/omap-serial.c 1485 1486 static int serial_omap_probe_rs485(struct uart_omap_port *up, 1487 struct device *dev) 1488 { 1489 struct serial_rs485 *rs485conf = &up->port.rs485; 1490 struct device_node *np = dev->of_node; 1491 enum gpiod_flags gflags; 1492 int ret; 1493 1494 rs485conf->flags = 0; 1495 up->rts_gpiod = NULL; 1496 1497 if (!np) 1498 return 0; 1499 1500 up->port.rs485_config = serial_omap_config_rs485; > 1501 up->port.rs485_supported = serial_omap_rs485_supported; 1502 1503 ret = uart_get_rs485_mode(&up->port); 1504 if (ret) 1505 return ret; 1506 1507 if (of_property_read_bool(np, "rs485-rts-active-high")) { 1508 rs485conf->flags |= SER_RS485_RTS_ON_SEND; 1509 rs485conf->flags &= ~SER_RS485_RTS_AFTER_SEND; 1510 } else { 1511 rs485conf->flags &= ~SER_RS485_RTS_ON_SEND; 1512 rs485conf->flags |= SER_RS485_RTS_AFTER_SEND; 1513 } 1514 1515 /* check for tx enable gpio */ 1516 gflags = rs485conf->flags & SER_RS485_RTS_AFTER_SEND ? 1517 GPIOD_OUT_HIGH : GPIOD_OUT_LOW; 1518 up->rts_gpiod = devm_gpiod_get_optional(dev, "rts", gflags); 1519 if (IS_ERR(up->rts_gpiod)) { 1520 ret = PTR_ERR(up->rts_gpiod); 1521 if (ret == -EPROBE_DEFER) 1522 return ret; 1523 1524 up->rts_gpiod = NULL; 1525 up->port.rs485_supported = (const struct serial_rs485) { }; 1526 if (rs485conf->flags & SER_RS485_ENABLED) { 1527 dev_err(dev, "disabling RS-485 (rts-gpio missing in device tree)\n"); 1528 memset(rs485conf, 0, sizeof(*rs485conf)); 1529 } 1530 } else { 1531 gpiod_set_consumer_name(up->rts_gpiod, "omap-serial"); 1532 } 1533 1534 return 0; 1535 } 1536 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki