From: Asmaa Mnebhi <asmaa@nvidia.com>
To: <davem@davemloft.net>, <marek.mojik@nic.cz>, <netdev@vger.kernel.org>
Cc: Asmaa Mnebhi <asmaa@nvidia.com>, <davthompson@nvidia.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation
Date: Wed, 27 Dec 2023 18:16:57 -0500 [thread overview]
Message-ID: <20231227231657.15152-1-asmaa@nvidia.com> (raw)
Very rarely, the KSZ9031 fails to complete autonegotiation although it was
initiated via phy_start(). As a result, the link stays down. Restarting
autonegotiation when in this state solves the issue.
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
v1->v2:
- Use msleep() instead of mdelay()
drivers/net/phy/micrel.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 08e3915001c3..9952a073413f 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1475,6 +1475,7 @@ static int ksz9031_get_features(struct phy_device *phydev)
static int ksz9031_read_status(struct phy_device *phydev)
{
+ u8 timeout = 10;
int err;
int regval;
@@ -1494,6 +1495,22 @@ static int ksz9031_read_status(struct phy_device *phydev)
return genphy_config_aneg(phydev);
}
+ /* KSZ9031's autonegotiation takes normally 4-5 seconds to complete.
+ * Occasionally it fails to complete autonegotiation. The workaround is
+ * to restart it.
+ */
+ if (phydev->autoneg == AUTONEG_ENABLE) {
+ while (timeout) {
+ if (phy_aneg_done(phydev))
+ break;
+ msleep(1000);
+ timeout--;
+ };
+
+ if (timeout == 0)
+ phy_restart_aneg(phydev);
+ }
+
return 0;
}
--
2.30.1
next reply other threads:[~2023-12-27 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 23:16 Asmaa Mnebhi [this message]
2023-12-28 8:43 ` [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation Florian Fainelli
2023-12-28 13:37 ` Asmaa Mnebhi
2023-12-28 14:09 ` Heiner Kallweit
2023-12-28 21:21 ` Asmaa Mnebhi
2023-12-28 14:17 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227231657.15152-1-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.mojik@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox