From: Al Viro <viro@zeniv.linux.org.uk>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tanzir Hasan <tanzirh@google.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <nnn@google.com>
Subject: Re: [PATCH] x86/syscalls: shrink entry/syscall_32.i via IWYU
Date: Thu, 28 Dec 2023 00:26:14 +0000 [thread overview]
Message-ID: <20231228002614.GI1674809@ZenIV> (raw)
In-Reply-To: <8B198413-0C9B-40A2-8478-F22206AAE6FA@zytor.com>
On Wed, Dec 27, 2023 at 03:50:33PM -0800, H. Peter Anvin wrote:
> > /*
> > * Only the low 32 bits of orig_ax are meaningful, so we return int.
> > * This importantly ignores the high bits on 64-bit, so comparisons
>
> __visible is for LTO, no?
If we need it in cases when array defined in entry/syscall_32.c and
used in entry/common.c, I would respectfully suggest that whatever
we need it for is misguided garbage. I don't think that LTO does
need it, though. How is arch/x86/entry/{syscall_32,common}.c
different from e.g. fs/{namespace,d_path}.c, where we have
fs/namespace.c:100:__cacheline_aligned_in_smp DEFINE_SEQLOCK(mount_lock);
and
fs/d_path.c:166: read_seqbegin_or_lock(&mount_lock, &m_seq);
respectively?
next prev parent reply other threads:[~2023-12-28 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:38 [PATCH] x86/syscalls: shrink entry/syscall_32.i via IWYU Tanzir Hasan
2023-12-27 23:34 ` Al Viro
2023-12-27 23:50 ` H. Peter Anvin
2023-12-28 0:26 ` Al Viro [this message]
2023-12-28 2:17 ` H. Peter Anvin
2023-12-28 0:17 ` Tanzir Hasan
2023-12-28 0:45 ` Al Viro
2024-01-03 16:50 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228002614.GI1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox