From: Al Viro <viro@zeniv.linux.org.uk>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>
Subject: Re: [PATCH] x86/syscalls: shrink entry/syscall_32.i via IWYU
Date: Thu, 28 Dec 2023 00:45:50 +0000 [thread overview]
Message-ID: <20231228004550.GJ1674809@ZenIV> (raw)
In-Reply-To: <20231227233444.GH1674809@ZenIV>
On Wed, Dec 27, 2023 at 11:34:44PM +0000, Al Viro wrote:
> That's _it_. The same goes for syscall_64.c and syscall_x32.c.
> Oh, and lose the __visible/asmlinkage junk in there - none of that
> stuff is used from asm these days. See the patch below -
> Untested But Should Work(tm):
Unfortunately, there's this in kernel/trace/trace_syscalls.c:
unsigned long __init __weak arch_syscall_addr(int nr)
{
return (unsigned long)sys_call_table[nr];
}
How is that supposed to work for anything biarch? Including
amd64 with CONFIG_COMPAT enabled?
Confused...
next prev parent reply other threads:[~2023-12-28 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:38 [PATCH] x86/syscalls: shrink entry/syscall_32.i via IWYU Tanzir Hasan
2023-12-27 23:34 ` Al Viro
2023-12-27 23:50 ` H. Peter Anvin
2023-12-28 0:26 ` Al Viro
2023-12-28 2:17 ` H. Peter Anvin
2023-12-28 0:17 ` Tanzir Hasan
2023-12-28 0:45 ` Al Viro [this message]
2024-01-03 16:50 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228004550.GJ1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox