From: Yue Hu <zbestahu@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org,
syzbot+6c746eea496f34b3161d@syzkaller.appspotmail.com,
LKML <linux-kernel@vger.kernel.org>,
huyue2@coolpad.com
Subject: Re: [PATCH] erofs: avoid debugging output for (de)compressed data
Date: Thu, 28 Dec 2023 09:29:55 +0800 [thread overview]
Message-ID: <20231228092955.00000520.zbestahu@gmail.com> (raw)
In-Reply-To: <20231227151903.2900413-1-hsiangkao@linux.alibaba.com>
On Wed, 27 Dec 2023 23:19:03 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> Syzbot reported a KMSAN warning,
> erofs: (device loop0): z_erofs_lz4_decompress_mem: failed to decompress -12 in[46, 4050] out[917]
> =====================================================
> BUG: KMSAN: uninit-value in hex_dump_to_buffer+0xae9/0x10f0 lib/hexdump.c:194
> ..
> print_hex_dump+0x13d/0x3e0 lib/hexdump.c:276
> z_erofs_lz4_decompress_mem fs/erofs/decompressor.c:252 [inline]
> z_erofs_lz4_decompress+0x257e/0x2a70 fs/erofs/decompressor.c:311
> z_erofs_decompress_pcluster fs/erofs/zdata.c:1290 [inline]
> z_erofs_decompress_queue+0x338c/0x6460 fs/erofs/zdata.c:1372
> z_erofs_runqueue+0x36cd/0x3830
> z_erofs_read_folio+0x435/0x810 fs/erofs/zdata.c:1843
>
> The root cause is that the printed decompressed buffer may be filled
> incompletely due to decompression failure. Since they were once only
> used for debugging, get rid of them now.
>
> Reported-by: syzbot+6c746eea496f34b3161d@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/r/000000000000321c24060d7cfa1c@google.com
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
next prev parent reply other threads:[~2023-12-28 1:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 12:31 [syzbot] [erofs?] KMSAN: uninit-value in z_erofs_lz4_decompress (2) syzbot
2023-12-27 15:19 ` [PATCH] erofs: avoid debugging output for (de)compressed data Gao Xiang
2023-12-28 1:29 ` Yue Hu [this message]
2023-12-28 1:11 ` [syzbot] [erofs?] KMSAN: uninit-value in z_erofs_lz4_decompress (2) syzbot
2023-12-28 3:36 ` Gao Xiang
2023-12-28 4:23 ` syzbot
2023-12-28 5:56 ` syzbot
2023-12-28 13:54 ` [syzbot] " syzbot
2023-12-28 14:08 ` syzbot
2023-12-28 22:12 ` syzbot
2023-12-29 11:09 ` [PATCH] erofs: fix uninit-value in z_erofs_lz4_decompress Edward Adam Davis
2023-12-31 1:14 ` Gao Xiang
2023-12-31 2:32 ` Edward Adam Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228092955.00000520.zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+6c746eea496f34b3161d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox