Re: [PATCH 1/2] dt-bindings: arm: sunxi: Add Sipeed Longan Module 3H and Longan Pi 3H

Andre Przywara
2023-12-29T23:56:36Z

On Thu, 28 Dec 2023 22:56:46 +0800
Jisheng Zhang <jszhang@kernel.org> wrote:

Hi Jisheng,

thanks for sending this, seems to be on time with the release of the
hardware. Don't see that very often!

> Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H
> board.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 11c5ce941dd7..34d8ae484e01 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -835,6 +835,13 @@ properties:
> - const: sinlinx,sina33
> - const: allwinner,sun8i-a33
>
> + - description: Sipeed Longan Pi 3H board for the Sipeed Longan Module 3H
> + items:
> + - enum:
> + - sipeed,longan-pi-3h

The picture of the SoM suggests that it cannot be used on its own, so
for anything usable we will always need both the SoM and some board.
Definitely we do for this board. So please follow the example for the
SoPine (or other SoM based boards), and just name all three names as
"const" items.

Cheers,
Andre

> + - const: sipeed,longan-module-3h
> + - const: allwinner,sun50i-h618
> +
> - description: SourceParts PopStick v1.1
> items:
> - const: sourceparts,popstick-v1.1