From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC85C4646D for ; Wed, 15 Aug 2018 10:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83FAE2159D for ; Wed, 15 Aug 2018 10:30:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83FAE2159D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729131AbeHONVh (ORCPT ); Wed, 15 Aug 2018 09:21:37 -0400 Received: from gloria.sntech.de ([185.11.138.130]:57256 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbeHONVh (ORCPT ); Wed, 15 Aug 2018 09:21:37 -0400 Received: from wd0180.dip.tu-dresden.de ([141.76.108.180] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fpt3s-0003d2-1n; Wed, 15 Aug 2018 12:29:56 +0200 From: Heiko Stuebner To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, amstan@chromium.org, groeck@google.com, kieran.bingham@ideasonboard.com, kernel@collabora.com, bleung@chromium.org, devicetree@vger.kernel.org, Frank Wang , linux-rockchip@lists.infradead.org, Rob Herring , Kishon Vijay Abraham I , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties. Date: Wed, 15 Aug 2018 12:29:55 +0200 Message-ID: <2023816.cqyDmH3see@phil> In-Reply-To: <20180815095934.11205-3-enric.balletbo@collabora.com> References: <20180815095934.11205-1-enric.balletbo@collabora.com> <20180815095934.11205-3-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: > Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for > rk3399") introduces two new properties. The extcon property is used to > detect the cable-state, and the rockchip,utmi-avalid is used to indicate > which register should be used to detect the vbus state. > > Document these properties in the documentation binding. > > Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") > Signed-off-by: Enric Balletbo i Serra > --- > > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > index 074a7b3b0425..2d4808d3920b 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > @@ -23,6 +23,7 @@ Optional properties: > register files". When set driver will request its > phandle as one companion-grf for some special SoCs > (e.g RV1108). > + - extcon : phandle to the extcon device for the otg phy. That should probably mention that this is the extcon providing the cable-state? > Required nodes : a sub-node is required for each port the phy provides. > The sub-node name is used to identify host or otg port, > @@ -45,6 +46,8 @@ Required properties (port (child) node): > Optional properties: > - phy-supply : phandle to a regulator that provides power to VBUS. > See ./phy-bindings.txt for details. > + - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. > + Otherwise, use the bvalid register. Not having looked to deeply into the usb2 phy, this might raise questions on why this is a hardware-description? Is this needed when something is not connected on the board? Heiko