Re: [PATCH v5] x86: intel_epb: Add earlyparam option to keep bias at performance

Dave Hansen
2024-01-03T15:17:50Z

On 1/3/24 06:46, Jack Allister wrote:
> + intel_epb= [X86]
> + auto
> + Same as not passing a parameter to intel_epb. This will
> + ensure that the intel_epb module will restore the energy
> + performance bias to "normal" at boot-time. This workaround
> + is for buggy BIOSes which may not set this value and cause
> + either overheating or excess power usage.
> + preserve
> + At kernel boot-time if the EPB value is read as "performance"
> + keep it at this value. This prevents the "performance" -> "normal"
> + transition which is a workaround mentioned above.

This ends up describing the nitty-gritty details of the implementation
instead of what users should take away from the options. Could we up
level this a bit?

How about this?

intel_epb= [X86]

auto (default)
Work around buggy BIOSes to avoid
excess power usage by forcing
performance bias to "normal" at boot-
time.

preserve
Do not override the existing performance
bias setting. Useful if a previous
kernel or bootloader's setting is more
desirable than "normal".

It's better formatted and uses the "(default)" tag instead of trying to
explain it in prose. It also explains when someone might want to use
the override instead of just explaining its function.