From: Miquel Raynal <miquel.raynal@bootlin.com>
To: POPESCU Catalin <catalin.popescu@leica-geosystems.com>
Cc: "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
"michael@walle.cc" <michael@walle.cc>,
"rafal@milecki.pl" <rafal@milecki.pl>,
"robh@kernel.org" <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GEO-CHHER-bsp-development
<bsp-development.geo@leica-geosystems.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH] nvmem: fix issue within nvmem_register with fixed-layout.
Date: Wed, 3 Jan 2024 09:40:13 +0100 [thread overview]
Message-ID: <20240103094013.2672cb7d@xps-13> (raw)
In-Reply-To: <20231205100502.623863ff@xps-13>
Hi Catalin,
miquel.raynal@bootlin.com wrote on Tue, 5 Dec 2023 10:05:02 +0100:
> Hi Catalin,
>
> + GKH
> + Luca (who initially reported this issue)
>
> catalin.popescu@leica-geosystems.com wrote on Tue, 5 Dec 2023 08:48:27
> +0000:
>
> > Adding more people.
> >
> > On 30.11.23 17:29, Catalin Popescu wrote:
> > > fixed-layout is natively supported by NVMEM framework.
> > > Yet, it's not been declared as a supported layout. As a
> > > result, nvmem_register always returns -EPROBE_DEFER if
> > > configuration has no layout and the NVMEM provider DT
> > > uses a fixed layout.
> > >
> > > As a fix, declare fixed-layout as a supported layout
> > > and use add_cells callback to parse the cells. This adds
> > > consistency over layouts parsing as fixed-layout parsing
> > > is handled in the same way than others nvmem layouts.
>
> I believe this patch (not taken yet) should fix your issue and should be
> queued to fixes.
>
> Link: https://lore.kernel.org/lkml/20231124193814.360552-1-miquel.raynal@bootlin.com/
>
> However I like your approach which should probably be taken into
> consideration for the next cycle, as I think it fits Rafal's
> original idea pretty well.
Do you plan on updating this patch at -rc1? I think it would be
interesting to follow your idea.
Thanks,
Miquèl
prev parent reply other threads:[~2024-01-03 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 16:29 [PATCH] nvmem: fix issue within nvmem_register with fixed-layout Catalin Popescu
2023-12-05 8:48 ` POPESCU Catalin
2023-12-05 9:05 ` Miquel Raynal
2024-01-03 8:40 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103094013.2672cb7d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michael@walle.cc \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox