From: Jiri Wiesner <jwiesner@suse.de>
To: Feng Tang <feng.tang@intel.com>
Cc: linux-kernel@vger.kernel.org, John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] clocksource: Skip watchdog check for large watchdog intervals
Date: Thu, 4 Jan 2024 17:48:29 +0100 [thread overview]
Message-ID: <20240104164828.GD3303@incl> (raw)
In-Reply-To: <ZZZISRg9YGyT2eQ+@feng-clx>
On Thu, Jan 04, 2024 at 01:55:21PM +0800, Feng Tang wrote:
> On Wed, Jan 03, 2024 at 12:21:13PM +0100, Jiri Wiesner wrote:
> > Fixes: 2e27e793e280 ("clocksource: Reduce clocksource-skew threshold")
>
> IIUC, the issue could happen even before this commit? Though I do think
> this is good stuff for stable kernel.
Yes, it could happen before 2e27e793e280 but the threshold was so loose
that it probably was an extremely rare event. Commit 2e27e793e280 lowered
the threshold and this significantly increased the likelihood of skew
detection failing for large watchdog intervals. We got a report of a
kernel with 2e27e793e280 switching to the HPET but there were no failures
with a kernel without 2e27e793e280 on the same fleet of 8 NUMA node machines.
> 0Day robot reported some compiling issue.
I am going to submit a v2 of the patch fixing the error after we clarify
the jiffies concern.
--
Jiri Wiesner
SUSE Labs
next prev parent reply other threads:[~2024-01-04 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 11:21 [PATCH] clocksource: Skip watchdog check for large watchdog intervals Jiri Wiesner
2024-01-03 22:08 ` Paul E. McKenney
2024-01-04 16:30 ` Jiri Wiesner
2024-01-04 19:19 ` Paul E. McKenney
2024-01-06 2:55 ` Feng Tang
2024-01-06 12:04 ` Paul E. McKenney
2024-01-04 0:46 ` kernel test robot
2024-01-04 0:57 ` kernel test robot
2024-01-04 5:55 ` Feng Tang
2024-01-04 16:48 ` Jiri Wiesner [this message]
2024-01-08 13:44 ` kernel test robot
2024-01-10 18:36 ` Jiri Wiesner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104164828.GD3303@incl \
--to=jwiesner@suse.de \
--cc=feng.tang@intel.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox