Re: [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()"

Bjorn Helgaas
2024-01-03T00:12:39Z

On Tue, Jan 02, 2024 at 03:33:51PM -0800, Kuppuswamy Sathyanarayanan wrote:
> On 1/2/2024 3:25 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > This reverts commit 08d0cc5f34265d1a1e3031f319f594bd1970976c.
> >
> > Michael reported that when attempting to resume from suspend to RAM on ASUS
> > mini PC PN51-BB757MDE1 (DMI model: MINIPC PN51-E1), 08d0cc5f3426
> > ("PCI/ASPM: Remove pcie_aspm_pm_state_change()") caused a 12-second delay
> > with no output, followed by a reboot.
> >
> > Workarounds include:
> >
> > - Reverting 08d0cc5f3426 ("PCI/ASPM: Remove pcie_aspm_pm_state_change()")
> > - Booting with "pcie_aspm=off"
> > - Booting with "pcie_aspm.policy=performance"
> > - "echo 0 | sudo tee /sys/bus/pci/devices/0000:03:00.0/link/l1_aspm"
> > before suspending
> > - Connecting a USB flash drive
>
> Did you find the root cause? Is this issue specific to that particular
> device? If yes, can we do a quirk?

Unfortunately we don't know the root cause yet. Without knowing the
root cause, I don't think we can make a good quirk.

Bjorn