From: Christoph Winklhofer via B4 Relay <devnull+cj.winklhofer.gmail.com@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Christoph Winklhofer <cj.winklhofer@gmail.com>,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org
Subject: [PATCH v4 0/3] w1: add UART w1 bus driver
Date: Sat, 06 Jan 2024 17:02:23 +0100 [thread overview]
Message-ID: <20240106-w1-uart-v4-0-7fe1378a8b3e@gmail.com> (raw)
Hello!
This patch contains a driver for a 1-Wire bus over UART. The driver
utilizes the UART interface via the Serial Device Bus to create the
1-Wire timing patterns.
Changes in v4:
- rework baud-rate configuration: also check max bit-time, support higher
baud-rates by adding a delay to complete 1-Wire cycle.
- dt-binding w1-uart: specify baud-rates for 1-Wire operations
- Link to v3: https://lore.kernel.org/r/20240105-w1-uart-v3-0-8687093b2e76@gmail.com
Changes in v3:
- improve baud-rate configuration: use specific limits for 1-Wire
reset, touch-0 and touch-1 operation, compute in nanoseconds.
- remove unused header atomic.h
- use function instead of macro to compute bit-time from baud-rate
- switch to b4 util to publish patch: missing recipients
- Link to v2: https://lore.kernel.org/lkml/20231223100408.44056-1-cj.winklhofer@gmail.com
Changes in v2:
- add documentation for dt-binding
- allow onewire as serial child node
- support different baud-rates: The driver requests a baud-rate (9600
for reset and 115200 for write/read) and tries to adapt the
transmitted byte according to the actual baud-rate returned from
serdev.
- fix locking problem for serdev-receive and w1-master reset/touch: The
received byte is now protected with a mutex - instead of the atomic,
which was used before due to the concurrent store and load.
- explicit error in serdev-receive: Receiving more than one byte results
in an error, since the w1-uart driver is the only writer, it writes a
single-byte and should receive a single byte.
- fix variable names, errno-returns, wrong define CONFIG_OF
- fix log flooding
- fix driver remove (error-path for rxtx-function)
- Link to v1: https://lore.kernel.org/all/20231217122004.42795-1-cj.winklhofer@gmail.com
Krzysztof, thank your very much for your feedback!
It was tested on a "Raspberry Pi 3 Model B+" with a DS18B20 and on a
"Variscite DART-6UL" with a DS18S20 temperature sensor.
Content:
- Patch 1: device tree binding 1-Wire
- Patch 2: allow onewire as serial child node
- Patch 3: driver and documentation
The patch was created against the w1 subsytem tree (branch w1-next):
Link: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git/
The checkpatch.pl script reported the following error - which I am not
sure how to fix:
WARNING: added, moved or deleted file(s), does MAINTAINERS need
updating?
The technical details for 1-Wire over UART are in the document:
Link: https://www.analog.com/en/technical-articles/using-a-uart-to-implement-a-1wire-bus-master.html
In short, the UART peripheral must support full-duplex and operate in
open-drain mode. The timing patterns are generated by a specific
combination of baud-rate and transmitted byte, which corresponds to a
1-Wire read bit, write bit or reset pulse.
For instance the timing pattern for a 1-Wire reset and presence detect
uses the baud-rate 9600, i.e. 104.2 us per bit. The transmitted byte
0xf0 over UART (least significant bit first, start-bit low) sets the
reset low time for 1-Wire to 521 us. A present 1-Wire device changes the
received byte by pulling the line low, which is used by the driver to
evaluate the result of the 1-Wire operation.
Similar for a 1-Wire read bit or write bit, which uses the baud-rate
115200, i.e. 8.7 us per bit. The transmitted byte 0x00 is used for a
Write-0 operation and the byte 0xff for Read-0, Read-1 and Write-1.
Hope the driver is helpful.
Thanks,
Christoph
Christoph Winklhofer (3):
dt-bindings: w1: UART 1-Wire bus
dt-bindings: serial: allow onewire as child node
w1: add UART w1 bus driver
.../devicetree/bindings/serial/serial.yaml | 2 +-
.../devicetree/bindings/w1/w1-uart.yaml | 44 +++
Documentation/w1/masters/index.rst | 1 +
Documentation/w1/masters/w1-uart.rst | 53 +++
drivers/w1/masters/Kconfig | 10 +
drivers/w1/masters/Makefile | 1 +
drivers/w1/masters/w1-uart.c | 307 ++++++++++++++++++
7 files changed, 417 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/w1/w1-uart.yaml
create mode 100644 Documentation/w1/masters/w1-uart.rst
create mode 100644 drivers/w1/masters/w1-uart.c
--
2.43.0
base-commit: efc19c44aa442197ddcbb157c6ca54a56eba8c4e
---
Christoph Winklhofer (3):
dt-bindings: w1: UART 1-Wire bus
dt-bindings: serial: allow onewire as child node
w1: add UART w1 bus driver
.../devicetree/bindings/serial/serial.yaml | 2 +-
Documentation/devicetree/bindings/w1/w1-uart.yaml | 62 ++++
Documentation/w1/masters/index.rst | 1 +
Documentation/w1/masters/w1-uart.rst | 54 +++
drivers/w1/masters/Kconfig | 10 +
drivers/w1/masters/Makefile | 1 +
drivers/w1/masters/w1-uart.c | 398 +++++++++++++++++++++
7 files changed, 527 insertions(+), 1 deletion(-)
---
base-commit: efc19c44aa442197ddcbb157c6ca54a56eba8c4e
change-id: 20240104-w1-uart-ee8685a15a50
Best regards,
--
Christoph Winklhofer <cj.winklhofer@gmail.com>
next reply other threads:[~2024-01-06 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 16:02 Christoph Winklhofer via B4 Relay [this message]
2024-01-06 16:02 ` [PATCH v4 1/3] dt-bindings: w1: UART 1-Wire bus Christoph Winklhofer via B4 Relay
2024-01-13 1:39 ` Rob Herring
2024-01-13 18:04 ` Christoph Winklhofer
2024-01-14 10:54 ` Krzysztof Kozlowski
2024-01-14 14:47 ` Christoph Winklhofer
2024-01-14 15:55 ` Krzysztof Kozlowski
2024-01-15 17:36 ` Christoph Winklhofer
2024-01-15 18:02 ` Krzysztof Kozlowski
2024-01-16 7:10 ` Christoph Winklhofer
2024-01-06 16:02 ` [PATCH v4 2/3] dt-bindings: serial: allow onewire as child node Christoph Winklhofer via B4 Relay
2024-01-13 1:40 ` Rob Herring
2024-01-06 16:02 ` [PATCH v4 3/3] w1: add UART w1 bus driver Christoph Winklhofer via B4 Relay
2024-01-08 6:18 ` Jiri Slaby
2024-01-08 18:03 ` Christoph Winklhofer
2024-01-08 19:29 ` Krzysztof Kozlowski
2024-01-06 16:56 ` [PATCH v4 0/3] " Krzysztof Kozlowski
2024-01-06 17:57 ` Christoph Winklhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240106-w1-uart-v4-0-7fe1378a8b3e@gmail.com \
--to=devnull+cj.winklhofer.gmail.com@kernel.org \
--cc=cj.winklhofer@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).