From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE7F41230; Mon, 8 Jan 2024 12:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mgYVC5Eb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61B28C433C8; Mon, 8 Jan 2024 12:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704716959; bh=0PQA5cRju5SGRkK5zQeqgk1bYVFbY1laOeFoitex2XU=; h=From:To:Cc:Subject:Date:From; b=mgYVC5Eb3mNsfQ0Hi/FTG1E4lgyYM3mGxwg6A/CvRz7A5U85hDQHAuuDMugCJrVco fNebf808UeYmS0BE/fd75haFNie3KpK+18G/km2b2fPomRyeHrqoyZsyUij15MGO9K opllQwM/REluROkdzP9Gk+ogtiWCPPdXp6sHyjDuf6tUAp0zu1oxmA8FqaiGJiCuz0 luKDxKLzSkjW2XJbrZnF9Lc5W98v2em0SQzMvBOht6CdM5NrK7opPHv8ei49Em7VJn qlmV6wkIyrKZnL3BZhlIStBLHfX5I3f2kme9y1IJibOL9YbcPr4IOJvbyX/9TxETFc navqAv8/s253g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Siddh Raman Pant , Krzysztof Kozlowski , Suman Ghosh , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 1/2] nfc: Do not send datagram if socket state isn't LLCP_BOUND Date: Mon, 8 Jan 2024 07:29:12 -0500 Message-ID: <20240108122915.2090922-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.265 Content-Transfer-Encoding: 8bit From: Siddh Raman Pant [ Upstream commit 6ec0d7527c4287369b52df3bcefd21a0c4fb2b7c ] As we know we cannot send the datagram (state can be set to LLCP_CLOSED by nfc_llcp_socket_release()), there is no need to proceed further. Thus, bail out early from llcp_sock_sendmsg(). Signed-off-by: Siddh Raman Pant Reviewed-by: Krzysztof Kozlowski Reviewed-by: Suman Ghosh Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/nfc/llcp_sock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index aea337d817025..91f5e3a2df8aa 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -798,6 +798,11 @@ static int llcp_sock_sendmsg(struct socket *sock, struct msghdr *msg, } if (sk->sk_type == SOCK_DGRAM) { + if (sk->sk_state != LLCP_BOUND) { + release_sock(sk); + return -ENOTCONN; + } + DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr, msg->msg_name); -- 2.43.0