From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A50C41202; Mon, 8 Jan 2024 13:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4T7vPL5z58z6K9V8; Mon, 8 Jan 2024 21:03:02 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id C5AE7140CB9; Mon, 8 Jan 2024 21:05:35 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 13:05:35 +0000 Date: Mon, 8 Jan 2024 13:05:34 +0000 From: Jonathan Cameron To: Ira Weiny CC: Dan Williams , Smita Koralahalli , Shiju Jose , Yazen Ghannam , "Davidlohr Bueso" , Dave Jiang , "Alison Schofield" , Vishal Verma , Ard Biesheuvel , , , Subject: Re: [PATCH v5 2/9] cxl/events: Promote CXL event structures to a core header Message-ID: <20240108130534.000022f5@Huawei.com> In-Reply-To: <20231220-cxl-cper-v5-2-1bb8a4ca2c7a@intel.com> References: <20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com> <20231220-cxl-cper-v5-2-1bb8a4ca2c7a@intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 20 Dec 2023 16:17:29 -0800 Ira Weiny wrote: > UEFI code can process CXL events through CPER records. Those records > use almost the same format as the CXL events. > > Lift the CXL event structures to a core header to be shared in later > patches. > > Signed-off-by: Ira Weiny As a side note, seems we need some updates in here for 3.1 additions. Job for another day. One trivial comment on 'extra' docs that will probably bit rot. Otherwise Reviewed-by: Jonathan Cameron > diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h > new file mode 100644 > index 000000000000..1c94e8fdd227 > --- /dev/null > +++ b/include/linux/cxl-event.h > @@ -0,0 +1,100 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_CXL_EVENT_H > +#define _LINUX_CXL_EVENT_H > + > +/* > + * CXL event records; CXL rev 3.0 That version number is nearly guaranteed to bit rot. I'd just not mention it here and keep the versioning local to the particular entries (where it is currently repeated). > + * > + * Copyright(c) 2023 Intel Corporation. > + */