From: Kees Cook <keescook@chromium.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: linux-hardening@vger.kernel.org, error27@gmail.com,
gustavoars@kernel.org, Bryan Tan <bryantan@vmware.com>,
Vishnu Dasa <vdasa@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, vegard.nossum@oracle.com,
darren.kenny@oracle.com
Subject: Re: [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc()
Date: Mon, 8 Jan 2024 14:28:30 -0800 [thread overview]
Message-ID: <202401081428.F7A80008D2@keescook> (raw)
In-Reply-To: <20240105164001.2129796-1-harshit.m.mogalapalli@oracle.com>
On Fri, Jan 05, 2024 at 08:39:59AM -0800, Harshit Mogalapalli wrote:
> Use struct_size() instead of open coding.
>
> Suggested-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Yeah, clear replacement.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-01-08 22:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 16:39 [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc() Harshit Mogalapalli
2024-01-05 16:40 ` [PATCH v2 2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() Harshit Mogalapalli
2024-01-05 17:11 ` Gustavo A. R. Silva
2024-01-08 7:33 ` Dan Carpenter
2024-01-08 17:03 ` Gustavo A. R. Silva
2024-01-08 17:31 ` Harshit Mogalapalli
2024-01-08 17:38 ` Gustavo A. R. Silva
2024-01-08 18:36 ` Dan Carpenter
2024-01-08 19:21 ` Gustavo A. R. Silva
2024-01-08 22:37 ` Kees Cook
2024-01-09 2:05 ` Gustavo A. R. Silva
2024-01-09 9:07 ` Dan Carpenter
2024-01-09 12:31 ` Gustavo A. R. Silva
2024-01-09 13:22 ` Dan Carpenter
2024-01-09 14:35 ` Gustavo A. R. Silva
2024-01-11 0:03 ` Kees Cook
2024-01-11 7:15 ` Dan Carpenter
2024-01-11 18:13 ` Kees Cook
2024-01-12 5:35 ` Dan Carpenter
2024-01-11 12:53 ` kovalev
2024-02-16 7:35 ` Harshit Mogalapalli
2024-01-05 16:57 ` [PATCH v2 1/2] VMCI: Use struct_size() in kmalloc() Gustavo A. R. Silva
2024-01-08 22:28 ` Kees Cook [this message]
2024-02-01 18:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401081428.F7A80008D2@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=bryantan@vmware.com \
--cc=darren.kenny@oracle.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=vdasa@vmware.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox