Re: [PATCH RFC v2 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

Krzysztof Kozlowski
2024-01-09T11:32:19Z

On 08/01/2024 19:32, Andrew Davis wrote:
> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from
> multiple vendors. Describe how the SGX GPU is integrated in these SoC,
> including register space and interrupts. Clocks, reset, and power domain
> information is SoC specific.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> .../bindings/gpu/img,powervr-sgx.yaml | 124 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 125 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr-sgx.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-sgx.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-sgx.yaml
> new file mode 100644
> index 0000000000000..bb821e1184de9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-sgx.yaml
> @@ -0,0 +1,124 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2023 Imagination Technologies Ltd.

Your email has @TI domain, are you sure you attribute your copyrights to
Imagination?

...

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks: true

Missing min/maxItems

> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: core
> + - const: mem
> + - const: sys
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false

This goes after allOf: block.

> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am6548-gpu
> + then:
> + required:
> + - power-domains
> + else:
> + properties:
> + power-domains: false
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun6i-a31-gpu
> + - ingenic,jz4780-gpu
> + then:
> + allOf:
> + - if:

I don't understand why do you need to embed allOf inside another allOf.
The upper (outer) if:then: looks entirely useless.

> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun6i-a31-gpu
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + minItems: 2
> + maxItems: 2

Best regards,
Krzysztof