* [PATCH -next] cxl: Remove duplicated include in cdat.c
@ 2024-01-09 0:47 Yang Li
2024-01-09 15:18 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Li @ 2024-01-09 0:47 UTC (permalink / raw)
To: jonathan.cameron, dave; +Cc: linux-cxl, linux-kernel, Yang Li
The header files core.h is included twice in cdat.c,
so one inclusion can be removed.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/cxl/core/cdat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
index f5e649407b8b..6fe11546889f 100644
--- a/drivers/cxl/core/cdat.c
+++ b/drivers/cxl/core/cdat.c
@@ -9,7 +9,6 @@
#include "cxlmem.h"
#include "core.h"
#include "cxl.h"
-#include "core.h"
struct dsmas_entry {
struct range dpa_range;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] cxl: Remove duplicated include in cdat.c
2024-01-09 0:47 [PATCH -next] cxl: Remove duplicated include in cdat.c Yang Li
@ 2024-01-09 15:18 ` Jonathan Cameron
2024-01-11 23:54 ` Dave Jiang
2024-01-12 0:45 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-01-09 15:18 UTC (permalink / raw)
To: Yang Li; +Cc: dave, linux-cxl, linux-kernel
On Tue, 9 Jan 2024 08:47:28 +0800
Yang Li <yang.lee@linux.alibaba.com> wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Obviously correct :)
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"
>
> struct dsmas_entry {
> struct range dpa_range;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] cxl: Remove duplicated include in cdat.c
2024-01-09 0:47 [PATCH -next] cxl: Remove duplicated include in cdat.c Yang Li
2024-01-09 15:18 ` Jonathan Cameron
@ 2024-01-11 23:54 ` Dave Jiang
2024-01-12 0:45 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2024-01-11 23:54 UTC (permalink / raw)
To: Yang Li, jonathan.cameron, dave; +Cc: linux-cxl, linux-kernel
On 1/8/24 17:47, Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"
>
> struct dsmas_entry {
> struct range dpa_range;
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH -next] cxl: Remove duplicated include in cdat.c
2024-01-09 0:47 [PATCH -next] cxl: Remove duplicated include in cdat.c Yang Li
2024-01-09 15:18 ` Jonathan Cameron
2024-01-11 23:54 ` Dave Jiang
@ 2024-01-12 0:45 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2024-01-12 0:45 UTC (permalink / raw)
To: Yang Li, jonathan.cameron, dave; +Cc: linux-cxl, linux-kernel, Yang Li
Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
> #include "cxlmem.h"
> #include "core.h"
> #include "cxl.h"
> -#include "core.h"
I believe that was due to a bad merge by me. That's fixed up now with a
better merge commit.
Thanks for spotting this though!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-12 0:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-09 0:47 [PATCH -next] cxl: Remove duplicated include in cdat.c Yang Li
2024-01-09 15:18 ` Jonathan Cameron
2024-01-11 23:54 ` Dave Jiang
2024-01-12 0:45 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox