From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc: Ingo Molnar <mingo@kernel.org>,
peterz@infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] objtool: Make objtool check actually fatal upon fatal errors
Date: Tue, 9 Jan 2024 12:20:53 -0800 [thread overview]
Message-ID: <20240109202053.ee26nc5kk5u5edrc@treble> (raw)
In-Reply-To: <CADWks+YO7zdFoYfLn+qwD8FyZoU1EfYCq1sghFkrn-nXANYMhw@mail.gmail.com>
On Tue, Jan 09, 2024 at 07:48:30PM +0000, Dimitri John Ledkov wrote:
> > Note the latter may be problematic at the moment due to some outstanding
> > warnings reported by Arnd and randconfig build bots. I try to fix those
> > when I can, but any help would be appreciated.
>
> I guess we can override CONFIG_WERROR during dkms compilations, but
> then i still want to ensofrce OBJTOOL errors.
>
> How abou introducing CONFIG_WERROR_OBJTOOL and make CONFIG_WERROR
> select CONFIG_WERROR_OBJTOOL? such that distributions can start to opt
> into CONFIG_WERROR_OBJTOOL for production builds, even if they cannot
> yet make the jump to CONFIG_WERROR?
Seems reasonable.
Though, keep in mind that even compiler warnings can cause boot failures
and security bugs. So I wouldn't recommend sleeping at night unless
your distro also has CONFIG_WERROR=y.
--
Josh
next prev parent reply other threads:[~2024-01-09 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231213134303.2302285-1-dimitri.ledkov@canonical.com>
2023-12-13 13:43 ` [PATCH v2 1/3] objtool: Make objtool check actually fatal upon fatal errors Dimitri John Ledkov
2024-01-08 9:15 ` Ingo Molnar
2024-01-09 19:24 ` Josh Poimboeuf
2024-01-09 19:48 ` Dimitri John Ledkov
2024-01-09 20:20 ` Josh Poimboeuf [this message]
2023-12-13 13:43 ` [PATCH v2 2/3] objtool: make objtool SLS validation fatal when building with CONFIG_SLS=y Dimitri John Ledkov
2024-01-08 9:16 ` Ingo Molnar
2024-01-09 19:31 ` Josh Poimboeuf
2023-12-13 13:43 ` [PATCH v2 3/3] objtool: make objtool RETPOLINE validation fatal when building with CONFIG_RETPOLINE=y Dimitri John Ledkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109202053.ee26nc5kk5u5edrc@treble \
--to=jpoimboe@kernel.org \
--cc=dimitri.ledkov@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox