From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Matlack <dmatlack@google.com>,
Xu Yilun <yilun.xu@linux.intel.com>,
Sean Christopherson <seanjc@google.com>
Subject: [PATCH 2/4] KVM: Put mm immediately after async #PF worker completes remote gup()
Date: Tue, 9 Jan 2024 17:15:31 -0800 [thread overview]
Message-ID: <20240110011533.503302-3-seanjc@google.com> (raw)
In-Reply-To: <20240110011533.503302-1-seanjc@google.com>
Put the async #PF worker's reference to the VM's address space as soon as
the worker is done with the mm. This will allow deferring getting a
reference to the worker itself without having to track whether or not
getting a reference succeeded.
Note, if the vCPU is still alive, there is no danger of the worker getting
stuck with tearing down the host page tables, as userspace also holds a
reference (obviously), i.e. there is no risk of delaying the page-present
notification due to triggering the slow path in mmput().
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
virt/kvm/async_pf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
index 876927a558ad..d5dc50318aa6 100644
--- a/virt/kvm/async_pf.c
+++ b/virt/kvm/async_pf.c
@@ -64,6 +64,7 @@ static void async_pf_execute(struct work_struct *work)
get_user_pages_remote(mm, addr, 1, FOLL_WRITE, NULL, &locked);
if (locked)
mmap_read_unlock(mm);
+ mmput(mm);
if (IS_ENABLED(CONFIG_KVM_ASYNC_PF_SYNC))
kvm_arch_async_page_present(vcpu, apf);
@@ -85,8 +86,6 @@ static void async_pf_execute(struct work_struct *work)
trace_kvm_async_pf_completed(addr, cr2_or_gpa);
__kvm_vcpu_wake_up(vcpu);
-
- mmput(mm);
}
static void kvm_flush_and_free_async_pf_work(struct kvm_async_pf *work)
--
2.43.0.472.g3155946c3a-goog
next prev parent reply other threads:[~2024-01-10 1:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 1:15 [PATCH 0/4] KVM: Async #PF fixes and cleanups Sean Christopherson
2024-01-10 1:15 ` [PATCH 1/4] KVM: Always flush async #PF workqueue when vCPU is being destroyed Sean Christopherson
2024-01-20 12:40 ` Xu Yilun
2024-01-24 19:04 ` Sean Christopherson
2024-01-26 7:36 ` Xu Yilun
2024-02-06 19:06 ` Sean Christopherson
2024-01-26 16:51 ` Vitaly Kuznetsov
2024-01-26 17:19 ` Sean Christopherson
2024-01-29 9:02 ` Vitaly Kuznetsov
2024-02-19 13:59 ` Xu Yilun
2024-02-19 15:51 ` Sean Christopherson
2024-02-20 3:02 ` Xu Yilun
2024-01-10 1:15 ` Sean Christopherson [this message]
2024-01-20 15:24 ` [PATCH 2/4] KVM: Put mm immediately after async #PF worker completes remote gup() Xu Yilun
2024-01-26 16:23 ` Vitaly Kuznetsov
2024-01-10 1:15 ` [PATCH 3/4] KVM: Get reference to VM's address space in the async #PF worker Sean Christopherson
2024-01-20 15:16 ` Xu Yilun
2024-01-24 18:52 ` Sean Christopherson
2024-01-26 8:06 ` Xu Yilun
2024-01-26 16:21 ` Vitaly Kuznetsov
2024-01-26 16:39 ` Sean Christopherson
2024-01-10 1:15 ` [PATCH 4/4] KVM: Nullify async #PF worker's "apf" pointer as soon as it might be freed Sean Christopherson
2024-01-20 15:24 ` Xu Yilun
2024-01-26 16:30 ` Vitaly Kuznetsov
2024-02-06 21:36 ` [PATCH 0/4] KVM: Async #PF fixes and cleanups Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110011533.503302-3-seanjc@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox