From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com
Subject: Re: [PATCH v10 1/2] ring-buffer: Introducing ring-buffer mapping functions
Date: Wed, 10 Jan 2024 08:42:05 +0900 [thread overview]
Message-ID: <20240110084205.2943f88bf8b797b04297b0ae@kernel.org> (raw)
In-Reply-To: <ZZ1ir0edlY3OzjyC@google.com>
On Tue, 9 Jan 2024 15:13:51 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:
> > > @@ -388,6 +389,7 @@ struct rb_irq_work {
> > > bool waiters_pending;
> > > bool full_waiters_pending;
> > > bool wakeup_full;
> > > + bool is_cpu_buffer;
> >
> > I think 'is_cpu_buffer' is a bit unclear (or generic),
> > what about 'meta_page_update'?
>
> Hum not sure about that change. This was really to identify if parent of
> rb_irq_work is a cpu_buffer or a trace_buffer. It can be a cpu_buffer regardless
> of the need to update the meta-page.
Yeah, I just meant that is "for_cpu_buffer", not "rb_irq_work is_cpu_buffer".
So when reading the code, I just felt uncomfortable.
Thank you,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-01-09 23:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 9:47 [PATCH v10 0/2] Introducing trace buffer mapping by user-space Vincent Donnefort
2024-01-05 9:47 ` [PATCH v10 1/2] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2024-01-09 14:42 ` Masami Hiramatsu
2024-01-09 15:13 ` Vincent Donnefort
2024-01-09 16:42 ` Steven Rostedt
2024-01-09 23:42 ` Masami Hiramatsu [this message]
2024-01-09 23:58 ` Steven Rostedt
2024-01-11 9:52 ` Vincent Donnefort
2024-01-11 9:57 ` Vincent Donnefort
2024-01-05 9:47 ` [PATCH v10 2/2] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
2024-01-09 13:04 ` [PATCH v10 0/2] Introducing trace buffer mapping by user-space Masami Hiramatsu
2024-01-09 13:20 ` Steven Rostedt
2024-01-09 13:47 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110084205.2943f88bf8b797b04297b0ae@kernel.org \
--to=mhiramat@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox