From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Rengarajan S <rengarajan.s@microchip.com>,
Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_pci1xxxx: fix off by one in pci1xxxx_process_read_data()
Date: Wed, 10 Jan 2024 21:07:42 +0100 [thread overview]
Message-ID: <2024011010-knickers-blighted-c177@gregkh> (raw)
In-Reply-To: <20240110144605.2a8813d4bfaff1a55edb9938@hugovil.com>
On Wed, Jan 10, 2024 at 02:46:05PM -0500, Hugo Villeneuve wrote:
> Hi,
> it is not simply a matter of adding "fix" to the title.
>
> You must explain what and why vs. how.
>
> Please see:
> https://cbea.ms/git-commit/#why-not-how
>
> for some guidelines on writing a good commit message.
Sorry, but no, Dan knows how to write a good commit message, this patch
is fine, I will take it as-is. Please do not nit-pick stuff like this.
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-10 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 19:25 [PATCH v2] serial: 8250_pci1xxxx: fix off by one in pci1xxxx_process_read_data() Dan Carpenter
2024-01-10 19:46 ` Hugo Villeneuve
2024-01-10 20:07 ` Greg Kroah-Hartman [this message]
2024-01-10 20:19 ` Dan Carpenter
2024-01-10 22:41 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011010-knickers-blighted-c177@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rengarajan.s@microchip.com \
--cc=tharunkumar.pasumarthi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox