* drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used
@ 2023-09-09 7:42 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-09-09 7:42 UTC (permalink / raw)
To: Brian King
Cc: oe-kbuild-all, linux-kernel, Martin K. Petersen, Damien Le Moal,
John Garry
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6099776f9f268e61fe5ecd721f994a8cfce5306f
commit: 65a15d6560dff065339f6cac91de4beded60fe3f scsi: ipr: Remove SATA support
date: 5 months ago
config: x86_64-randconfig-005-20230909 (https://download.01.org/0day-ci/archive/20230909/202309091516.3PVdvSso-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309091516.3PVdvSso-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309091516.3PVdvSso-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/scsi/ipr.c: In function 'ipr_init_res_entry':
drivers/scsi/ipr.c:1104:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
1104 | unsigned int proto;
| ^~~~~
drivers/scsi/ipr.c: In function 'ipr_update_res_entry':
drivers/scsi/ipr.c:1261:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
1261 | unsigned int proto;
| ^~~~~
drivers/scsi/ipr.c: In function 'ipr_change_queue_depth':
drivers/scsi/ipr.c:4417:29: warning: variable 'res' set but not used [-Wunused-but-set-variable]
4417 | struct ipr_resource_entry *res;
| ^~~
drivers/scsi/ipr.c: In function 'ipr_process_hrrq':
>> drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used [-Wunused-but-set-variable]
5430 | u32 ioasc;
| ^~~~~
vim +/ioasc +5430 drivers/scsi/ipr.c
3feeb89d40cc0ab Wayne Boyer 2009-10-20 5426
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5427 static int ipr_process_hrrq(struct ipr_hrr_queue *hrr_queue, int budget,
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5428 struct list_head *doneq)
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5429 {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 @5430 u32 ioasc;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5431 u16 cmd_index;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5432 struct ipr_cmnd *ipr_cmd;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5433 struct ipr_ioa_cfg *ioa_cfg = hrr_queue->ioa_cfg;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5434 int num_hrrq = 0;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5435
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5436 /* If interrupts are disabled, ignore the interrupt */
56d6aa33d3f6847 wenxiong@linux.vnet.ibm.com 2013-01-11 5437 if (!hrr_queue->allow_interrupts)
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5438 return 0;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5439
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5440 while ((be32_to_cpu(*hrr_queue->hrrq_curr) & IPR_HRRQ_TOGGLE_BIT) ==
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5441 hrr_queue->toggle_bit) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5442
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5443 cmd_index = (be32_to_cpu(*hrr_queue->hrrq_curr) &
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5444 IPR_HRRQ_REQ_RESP_HANDLE_MASK) >>
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5445 IPR_HRRQ_REQ_RESP_HANDLE_SHIFT;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5446
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5447 if (unlikely(cmd_index > hrr_queue->max_cmd_id ||
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5448 cmd_index < hrr_queue->min_cmd_id)) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5449 ipr_isr_eh(ioa_cfg,
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5450 "Invalid response handle from IOA: ",
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5451 cmd_index);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5452 break;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5453 }
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5454
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5455 ipr_cmd = ioa_cfg->ipr_cmnd_list[cmd_index];
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5456 ioasc = be32_to_cpu(ipr_cmd->s.ioasa.hdr.ioasc);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5457
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5458 ipr_trc_hook(ipr_cmd, IPR_TRACE_FINISH, ioasc);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5459
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5460 list_move_tail(&ipr_cmd->queue, doneq);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5461
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5462 if (hrr_queue->hrrq_curr < hrr_queue->hrrq_end) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5463 hrr_queue->hrrq_curr++;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5464 } else {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5465 hrr_queue->hrrq_curr = hrr_queue->hrrq_start;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5466 hrr_queue->toggle_bit ^= 1u;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5467 }
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5468 num_hrrq++;
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5469 if (budget > 0 && num_hrrq >= budget)
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5470 break;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5471 }
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5472
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5473 return num_hrrq;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5474 }
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5475
:::::: The code at line 5430 was first introduced by commit
:::::: 05a6538a9a204999e0c0f7faee00b81b334f4fc7 [SCSI] ipr: Add support for MSI-X and distributed completion
:::::: TO: wenxiong@linux.vnet.ibm.com <wenxiong@linux.vnet.ibm.com>
:::::: CC: James Bottomley <JBottomley@Parallels.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used
@ 2024-01-10 3:06 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-01-10 3:06 UTC (permalink / raw)
To: Brian King
Cc: llvm, oe-kbuild-all, linux-kernel, Martin K. Petersen,
Damien Le Moal, John Garry
Hi Brian,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ab27740f76654ed58dd32ac0ba0031c18a6dea3b
commit: 65a15d6560dff065339f6cac91de4beded60fe3f scsi: ipr: Remove SATA support
date: 9 months ago
config: i386-buildonly-randconfig-002-20240107 (https://download.01.org/0day-ci/archive/20240110/202401101004.fcxlPdWI-lkp@intel.com/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240110/202401101004.fcxlPdWI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401101004.fcxlPdWI-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/scsi/ipr.c:1104:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
1104 | unsigned int proto;
| ^
drivers/scsi/ipr.c:1261:15: warning: variable 'proto' set but not used [-Wunused-but-set-variable]
1261 | unsigned int proto;
| ^
drivers/scsi/ipr.c:4417:29: warning: variable 'res' set but not used [-Wunused-but-set-variable]
4417 | struct ipr_resource_entry *res;
| ^
>> drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used [-Wunused-but-set-variable]
5430 | u32 ioasc;
| ^
4 warnings generated.
vim +/ioasc +5430 drivers/scsi/ipr.c
3feeb89d40cc0ab Wayne Boyer 2009-10-20 5426
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5427 static int ipr_process_hrrq(struct ipr_hrr_queue *hrr_queue, int budget,
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5428 struct list_head *doneq)
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5429 {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 @5430 u32 ioasc;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5431 u16 cmd_index;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5432 struct ipr_cmnd *ipr_cmd;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5433 struct ipr_ioa_cfg *ioa_cfg = hrr_queue->ioa_cfg;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5434 int num_hrrq = 0;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5435
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5436 /* If interrupts are disabled, ignore the interrupt */
56d6aa33d3f6847 wenxiong@linux.vnet.ibm.com 2013-01-11 5437 if (!hrr_queue->allow_interrupts)
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5438 return 0;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5439
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5440 while ((be32_to_cpu(*hrr_queue->hrrq_curr) & IPR_HRRQ_TOGGLE_BIT) ==
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5441 hrr_queue->toggle_bit) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5442
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5443 cmd_index = (be32_to_cpu(*hrr_queue->hrrq_curr) &
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5444 IPR_HRRQ_REQ_RESP_HANDLE_MASK) >>
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5445 IPR_HRRQ_REQ_RESP_HANDLE_SHIFT;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5446
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5447 if (unlikely(cmd_index > hrr_queue->max_cmd_id ||
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5448 cmd_index < hrr_queue->min_cmd_id)) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5449 ipr_isr_eh(ioa_cfg,
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5450 "Invalid response handle from IOA: ",
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5451 cmd_index);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5452 break;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5453 }
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5454
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5455 ipr_cmd = ioa_cfg->ipr_cmnd_list[cmd_index];
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5456 ioasc = be32_to_cpu(ipr_cmd->s.ioasa.hdr.ioasc);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5457
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5458 ipr_trc_hook(ipr_cmd, IPR_TRACE_FINISH, ioasc);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5459
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5460 list_move_tail(&ipr_cmd->queue, doneq);
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5461
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5462 if (hrr_queue->hrrq_curr < hrr_queue->hrrq_end) {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5463 hrr_queue->hrrq_curr++;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5464 } else {
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5465 hrr_queue->hrrq_curr = hrr_queue->hrrq_start;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5466 hrr_queue->toggle_bit ^= 1u;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5467 }
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5468 num_hrrq++;
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5469 if (budget > 0 && num_hrrq >= budget)
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5470 break;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5471 }
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5472
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5473 return num_hrrq;
05a6538a9a20499 wenxiong@linux.vnet.ibm.com 2013-01-11 5474 }
b53d124a154d002 wenxiong@linux.vnet.ibm.com 2013-01-11 5475
:::::: The code at line 5430 was first introduced by commit
:::::: 05a6538a9a204999e0c0f7faee00b81b334f4fc7 [SCSI] ipr: Add support for MSI-X and distributed completion
:::::: TO: wenxiong@linux.vnet.ibm.com <wenxiong@linux.vnet.ibm.com>
:::::: CC: James Bottomley <JBottomley@Parallels.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-10 3:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 3:06 drivers/scsi/ipr.c:5430:6: warning: variable 'ioasc' set but not used kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-09-09 7:42 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox