From: David Wang <00107082@163.com>
To: ale.crismani@automattic.com, kadlec@netfilter.org,
xiaolinkui@kylinos.cn, pablo@netfilter.org
Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: Performance regression in ip_set_swap on 6.1.69
Date: Wed, 10 Jan 2024 18:23:42 +0800 [thread overview]
Message-ID: <20240110102342.4978-1-00107082@163.com> (raw)
In-Reply-To: <C0829B10-EAA6-4809-874E-E1E9C05A8D84@automattic.com>
I confirmed this on 6.7 that this was introduced by commit 28628fa952fefc7f2072ce6e8016968cc452b1ba with following changes:
static inline void
@@ -1397,6 +1394,9 @@ static int ip_set_swap(struct sk_buff *skb, const struct nfnl_info *info,
ip_set(inst, to_id) = from;
write_unlock_bh(&ip_set_ref_lock);
+ /* Make sure all readers of the old set pointers are completed. */
+ synchronize_rcu();
+
return 0;
}
synchronize_rcu causes the delay, and its usage here is very confusing, there is no reclaimer code after it.
FYI
David
next prev parent reply other threads:[~2024-01-10 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 22:45 Performance regression in ip_set_swap on 6.1.69 Ale Crismani
2024-01-10 10:23 ` David Wang [this message]
2024-01-10 10:35 ` Jozsef Kadlecsik
2024-01-10 11:05 ` David Wang
2024-01-10 11:30 ` David Wang
2024-01-10 16:14 ` Jozsef Kadlecsik
2024-01-11 8:25 ` Jozsef Kadlecsik
2024-01-11 11:11 ` David Wang
2024-01-11 11:22 ` Jozsef Kadlecsik
2024-01-11 14:53 ` Re:Performance regression in ip_set_swap on 6.7.0 David Wang
2024-01-13 18:24 ` Jozsef Kadlecsik
2024-01-14 5:30 ` David Wang
2024-01-14 20:38 ` Performance " Ale Crismani
2024-01-15 13:29 ` Ale Crismani
2024-01-16 7:57 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110102342.4978-1-00107082@163.com \
--to=00107082@163.com \
--cc=ale.crismani@automattic.com \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiaolinkui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox