public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: chenxb <chenxb_99091@126.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fw:[PATCH] mfd: Clean up errors in lm3533.h
Date: Wed, 10 Jan 2024 12:53:55 +0000	[thread overview]
Message-ID: <20240110125355.GH7948@google.com> (raw)
In-Reply-To: <6415c2b.7f89.18cf3465704.Coremail.chenxb_99091@126.com>

On Wed, 10 Jan 2024, chenxb wrote:

Subject should be:

  "mfd: lm3533: Remove superfluous whitespace in DEVICE_ATTR()

> Fix the following errors reported by checkpatch:
> 
> 

No double line spaces required.

> ERROR: space prohibited before that ',' (ctx:WxW)
> 
> Signed-off-by: GuoHua Chen <XueBing Chen@jari.cn>

That does not look like a correct email address.

> ---
>  include/linux/mfd/lm3533.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/lm3533.h b/include/linux/mfd/lm3533.h
> index 77092f6363ad..14fde840af67 100644
> --- a/include/linux/mfd/lm3533.h
> +++ b/include/linux/mfd/lm3533.h
> @@ -13,7 +13,7 @@
>  #define LM3533_ATTR_RO(_name) \
>  	DEVICE_ATTR(_name, S_IRUGO, show_##_name, NULL)
>  #define LM3533_ATTR_RW(_name) \
> -	DEVICE_ATTR(_name, S_IRUGO | S_IWUSR , show_##_name, store_##_name)
> +	DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, show_##_name, store_##_name)
>  
>  struct device;
>  struct regmap;
> -- 
> 2.17.1

-- 
Lee Jones [李琼斯]

           reply	other threads:[~2024-01-10 12:53 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <6415c2b.7f89.18cf3465704.Coremail.chenxb_99091@126.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110125355.GH7948@google.com \
    --to=lee@kernel.org \
    --cc=chenxb_99091@126.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox