From: Lee Jones <lee@kernel.org>
To: chenxuebing <chenxb_99091@126.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl: Clean up errors in twl.h
Date: Thu, 11 Jan 2024 11:38:00 +0000 [thread overview]
Message-ID: <20240111113800.GI1678981@google.com> (raw)
In-Reply-To: <20240111014555.5117-1-chenxb_99091@126.com>
The subject needs to be improved.
Succinctly explain what you're doing.
On Thu, 11 Jan 2024, chenxuebing wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited after that open parenthesis '('
> ERROR: open brace '{' following function definitions go on the next line
>
> Signed-off-by: chenxuebing <chenxb_99091@126.com>
Is this your first or last name, or both?
> ---
> include/linux/mfd/mcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
> index fd5cafc77e8a..ed56c67bbbc7 100644
> --- a/include/linux/mfd/mcp.h
> +++ b/include/linux/mfd/mcp.h
> @@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
> void mcp_driver_unregister(struct mcp_driver *);
>
> #define mcp_get_drvdata(mcp) dev_get_drvdata(&(mcp)->attached_device)
> -#define mcp_set_drvdata(mcp,d) dev_set_drvdata(&(mcp)->attached_device, d)
> +#define mcp_set_drvdata(mcp, d) dev_set_drvdata(&(mcp)->attached_device, d)
The code is fine, obviously.
> static inline void *mcp_priv(struct mcp *mcp)
> {
> --
> 2.17.1
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-01-11 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 1:45 [PATCH] mfd: twl: Clean up errors in twl.h chenxuebing
2024-01-11 11:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111113800.GI1678981@google.com \
--to=lee@kernel.org \
--cc=chenxb_99091@126.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox