public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: twl: Clean up errors in twl.h
@ 2024-01-11  1:45 chenxuebing
  2024-01-11 11:38 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: chenxuebing @ 2024-01-11  1:45 UTC (permalink / raw)
  To: lee; +Cc: linux-kernel, chenxuebing

Fix the following errors reported by checkpatch:

ERROR: space prohibited after that open parenthesis '('
ERROR: open brace '{' following function definitions go on the next line

Signed-off-by: chenxuebing <chenxb_99091@126.com>
---
 include/linux/mfd/mcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
index fd5cafc77e8a..ed56c67bbbc7 100644
--- a/include/linux/mfd/mcp.h
+++ b/include/linux/mfd/mcp.h
@@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
 void mcp_driver_unregister(struct mcp_driver *);
 
 #define mcp_get_drvdata(mcp)	dev_get_drvdata(&(mcp)->attached_device)
-#define mcp_set_drvdata(mcp,d)	dev_set_drvdata(&(mcp)->attached_device, d)
+#define mcp_set_drvdata(mcp, d)	dev_set_drvdata(&(mcp)->attached_device, d)
 
 static inline void *mcp_priv(struct mcp *mcp)
 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: twl: Clean up errors in twl.h
  2024-01-11  1:45 [PATCH] mfd: twl: Clean up errors in twl.h chenxuebing
@ 2024-01-11 11:38 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-01-11 11:38 UTC (permalink / raw)
  To: chenxuebing; +Cc: linux-kernel

The subject needs to be improved.

Succinctly explain what you're doing.

On Thu, 11 Jan 2024, chenxuebing wrote:

> Fix the following errors reported by checkpatch:
> 
> ERROR: space prohibited after that open parenthesis '('
> ERROR: open brace '{' following function definitions go on the next line
> 
> Signed-off-by: chenxuebing <chenxb_99091@126.com>

Is this your first or last name, or both?

> ---
>  include/linux/mfd/mcp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
> index fd5cafc77e8a..ed56c67bbbc7 100644
> --- a/include/linux/mfd/mcp.h
> +++ b/include/linux/mfd/mcp.h
> @@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
>  void mcp_driver_unregister(struct mcp_driver *);
>  
>  #define mcp_get_drvdata(mcp)	dev_get_drvdata(&(mcp)->attached_device)
> -#define mcp_set_drvdata(mcp,d)	dev_set_drvdata(&(mcp)->attached_device, d)
> +#define mcp_set_drvdata(mcp, d)	dev_set_drvdata(&(mcp)->attached_device, d)

The code is fine, obviously.

>  static inline void *mcp_priv(struct mcp *mcp)
>  {
> -- 
> 2.17.1
> 

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-11 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11  1:45 [PATCH] mfd: twl: Clean up errors in twl.h chenxuebing
2024-01-11 11:38 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox