From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26C6E4C3C8; Thu, 11 Jan 2024 14:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F+8o1Drq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 723B7C433C7; Thu, 11 Jan 2024 14:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704984706; bh=i6f1/14PJrdRngdxu4TuN5mOilOfj8PHEW7GGTEZJiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F+8o1DrqtUWhBa87fT4v82Wvy/YQVwC1mEqvqUNVDilj/Txs9G4tdBRsIrQneD8aN CKv/E+I2mvkAPkag3fPsvsX8JDmZcx6zpOoJB+WcEE6muCUdZTke3oieaNZpyR6sH7 BsXK0CBkm2FyzL0Eco+F2CVqrs6iyVaWqJi3sx3fQRUU0/A90RefriChN/cHF0J8fh 7bAUobB2VfLz7B9dHmcvjj/HVECT7l7CfSy+qMF79VGu+N86iqX34HaPvg9B3rKGqv kURYtc5Jj2n9hUkzNztl6Iwn7fuSkutM4o54qYtBWyv9Inr7XhAal9SP5gGRc93s7u dakJBS9MpGftQ== Date: Thu, 11 Jan 2024 08:51:44 -0600 From: Rob Herring To: Raphael Gallais-Pou Cc: Yannick Fertre , Philippe Cornu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philipp Zabel , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device Message-ID: <20240111145144.GA528743-robh@kernel.org> References: <20240111104049.38695-1-raphael.gallais-pou@foss.st.com> <20240111104049.38695-2-raphael.gallais-pou@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111104049.38695-2-raphael.gallais-pou@foss.st.com> On Thu, Jan 11, 2024 at 11:40:44AM +0100, Raphael Gallais-Pou wrote: > Add "st,stm32-lvds" compatible. > > Signed-off-by: Raphael Gallais-Pou > --- > Changes in v2: > - Switch compatible and clock-cells related areas > - Remove faulty #include in the example. > - Add entry in MAINTAINERS > --- > .../bindings/display/st,stm32-lvds.yaml | 117 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/st,stm32-lvds.yaml b/Documentation/devicetree/bindings/display/st,stm32-lvds.yaml > new file mode 100644 > index 000000000000..8dfc6e88f260 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/st,stm32-lvds.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/st,stm32-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 LVDS Display Interface Transmitter > + > +maintainers: > + - Raphael Gallais-Pou > + - Yannick Fertre > + > +description: | > + The STMicroelectronics STM32 LVDS Display Interface Transmitter handles the > + LVDS protocol: it maps the pixels received from the upstream Pixel-DMA (LTDC) > + onto the LVDS PHY. > + > + It regroups three sub blocks: regroups means rearranging. Perhaps 'contains' or 'is composed of' instead. > + - LVDS host: handles the LVDS protocol (FPD / OpenLDI) and maps its input > + pixels onto the data lanes of the PHY > + - LVDS PHY: parallelize the data and drives the LVDS data lanes > + - LVDS wrapper: handles top-level settings > + > + The LVDS controller driver supports the following high-level features: > + - FDP-Link-I and OpenLDI (v0.95) protocols > + - Single-Link or Dual-Link operation > + - Single-Display or Double-Display (with the same content duplicated on both) > + - Flexible Bit-Mapping, including JEIDA and VESA > + - RGB888 or RGB666 output > + - Synchronous design, with one input pixel per clock cycle > + > +properties: > + compatible: > + const: st,stm32-lvds SoC specific compatible needed. > + > + "#clock-cells": > + const: 0 What clock is provided? > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: APB peripheral clock > + - description: Reference clock for the internal PLL > + > + clock-names: > + items: > + - const: pclk > + - const: ref > + > + resets: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: | Don't need '|' if no formatting to preserve. > + LVDS input port node, connected to the LTDC RGB output port. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: | > + LVDS output port node, connected to a panel or bridge input port. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - "#clock-cells" > + - reg > + - clocks > + - clock-names > + - resets > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + lvds: lvds@48060000 { > + compatible = "st,stm32-lvds"; > + reg = <0x48060000 0x2000>; > + #clock-cells = <0>; > + clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>; > + clock-names = "pclk", "ref"; > + resets = <&rcc LVDS_R>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds_in: endpoint { > + remote-endpoint = <<dc_ep1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds_out0: endpoint { > + remote-endpoint = <&lvds_panel_in>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 9d959a6881f7..0b6ec5347195 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7193,6 +7193,7 @@ L: dri-devel@lists.freedesktop.org > S: Maintained > T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > +F: Documentation/devicetree/bindings/display/st,stm32-lvds.yaml > F: drivers/gpu/drm/stm > > DRM DRIVERS FOR TI KEYSTONE > -- > 2.25.1 >