Re: [PATCH] mm: Update mark_victim tracepoints fields

Carlos Galo
2024-01-11T21:20:45Z

On Thu, Jan 11, 2024 at 9:08 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Carlos,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 0dd3ee31125508cd67f7e7172247f05b7fd1753a]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Carlos-Galo/mm-Update-mark_victim-tracepoints-fields/20240111-081635
> base: 0dd3ee31125508cd67f7e7172247f05b7fd1753a
> patch link: https://lore.kernel.org/r/20240111001155.746-1-carlosgalo%40google.com
> patch subject: [PATCH] mm: Update mark_victim tracepoints fields
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240112/202401120052.rdFjpivG-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240112/202401120052.rdFjpivG-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401120052.rdFjpivG-lkp@intel.com/
>

Sorry, I missed a comma in my final editing.
I posted a V2 here:
https://lore.kernel.org/lkml/20240111210539.636607-1-carlosgalo@google.com/

Thanks,
Carlos

> All errors (new ones prefixed by >>):
>
> In file included from include/trace/define_trace.h:102,
> from include/trace/events/oom.h:206,
> from mm/oom_kill.c:54:
> include/trace/events/oom.h: In function 'trace_raw_output_mark_victim':
> >> include/trace/stages/stage3_trace_output.h:6:17: error: called object is not a function or function pointer
> 6 | #define __entry field
> | ^~~~~
> include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 203 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
> 45 | PARAMS(print)); \
> | ^~~~~~
> include/trace/events/oom.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(mark_victim,
> | ^~~~~~~~~~~
> include/trace/events/oom.h:93:9: note: in expansion of macro 'TP_printk'
> 93 | TP_printk("pid=%d uid=%u comm=%s oom_score_adj=%hd",
> | ^~~~~~~~~
> include/trace/events/oom.h:95:17: note: in expansion of macro '__entry'
> 95 | __entry->uid
> | ^~~~~~~
> >> include/trace/trace_events.h:203:39: error: expected expression before ')' token
> 203 | trace_event_printf(iter, print); \
> | ^
> include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLARE_EVENT_CLASS'
> 40 | DECLARE_EVENT_CLASS(name, \
> | ^~~~~~~~~~~~~~~~~~~
> include/trace/events/oom.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(mark_victim,
> | ^~~~~~~~~~~
>
>
> vim +6 include/trace/stages/stage3_trace_output.h
>
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Google 2022-03-03 4)
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Google 2022-03-03 5) #undef __entry
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Google 2022-03-03 @6) #define __entry field
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Google 2022-03-03 7)
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki