From: Alex Williamson <alex.williamson@redhat.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: diana.craciun@oss.nxp.com, eric.auger@redhat.com,
Bharat.Bhushan@nxp.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/fsl-mc: Remove unnecessary free in vfio_set_trigger
Date: Fri, 12 Jan 2024 08:35:49 -0700 [thread overview]
Message-ID: <20240112083549.04db8f8a.alex.williamson@redhat.com> (raw)
In-Reply-To: <20240112072128.141954-1-chentao@kylinos.cn>
On Fri, 12 Jan 2024 15:21:28 +0800
Kunwu Chan <chentao@kylinos.cn> wrote:
> 'irq->name' is initialed by kasprintf, so there is no need
> to free it before initializing.
This is just as bogus as the vfio-platform version. Thanks,
Alex
> Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> index d62fbfff20b8..31f0716e7ab3 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev,
> hwirq = vdev->mc_dev->irqs[index]->virq;
> if (irq->trigger) {
> free_irq(hwirq, irq);
> - kfree(irq->name);
> eventfd_ctx_put(irq->trigger);
> irq->trigger = NULL;
> }
prev parent reply other threads:[~2024-01-12 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 7:21 [PATCH] vfio/fsl-mc: Remove unnecessary free in vfio_set_trigger Kunwu Chan
2024-01-12 15:35 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112083549.04db8f8a.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=Bharat.Bhushan@nxp.com \
--cc=chentao@kylinos.cn \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox