Re: [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with audio codec properties

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2048 bytes --]

On Wed, Jan 17, 2024 at 12:21:02AM +1100, Tim Lunn wrote:
> Update the example provided to include the properties for using
> rk817 audio codec.
> 
> Signed-off-by: Tim Lunn <tim@feathertop.org>
> 
> ---
> 
> Changes in v2:
> - Fix missing include and pinctrl for codec example
> 
>  .../devicetree/bindings/mfd/rockchip,rk809.yaml          | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index 9b9d670708ce..fee8338b230b 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -147,6 +147,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/px30-cru.h>
>      #include <dt-bindings/pinctrl/rockchip.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/gpio/gpio.h>
> @@ -161,10 +162,13 @@ examples:
>              clock-output-names = "xin32k", "rk808-clkout2";
>              interrupt-parent = <&gpio3>;
>              interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
> +            clock-names = "mclk";
> +            clocks = <&cru SCLK_I2S1_OUT>;
>              pinctrl-names = "default";
> -            pinctrl-0 = <&pmic_int_l_pin>;
> +            pinctrl-0 = <&pmic_int_l_pin>, <&i2s1_2ch_mclk>;
>              rockchip,system-power-controller;
>              wakeup-source;
> +            #sound-dai-cells = <0>;
>  
>              vcc1-supply = <&vcc_sysin>;
>              vcc2-supply = <&vcc_sysin>;
> @@ -309,5 +313,8 @@ examples:
>                      };
>                  };
>              };

Blank line here please.
I'd squash this with the patch adding the codec as an allowed property
though.

Thanks,
Conor.

> +            rk817_codec: codec {
> +                rockchip,mic-in-differential;
> +            };
>          };
>      };
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]