From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9947D134CC; Tue, 16 Jan 2024 00:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G/RH11N3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8991FC433C7; Tue, 16 Jan 2024 00:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364616; bh=Xu5aDG6VKhjO7Qw88dpdP3PSA2esceo3TBRKh5OeS8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G/RH11N3pqn/ArLc4xXm1ObVGvkHtMehuT85VkqdQANcQpaxc1EgyA/eXY8TEIj6E 31/mtoZZv90E4Q+cyJ6zNpEtzRA+Mfa5vVVCYq2YMOHvkx/JEjuQ66gQsROEEamD6M pGHrHkQTWVztTEYngih22NT4FaxDXaRprPkm8G2AmXh+lgvy/6PConhcP0x1Iwy1FY gABFx0nt+IaH+97ZqnzZ8Y4VJm9jx5LqWJHnxgApe/IqiBTNKMOXxgBrCrPz5zkk8C vLND80qHrMYf/4rF3wu5drCKjh/Q7Z+6GUuzOlOqZBLbiPHyHQT5rUWCA+FS5rjvxX G3PcHdKG0RBCw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia Jie Ho , Herbert Xu , Sasha Levin , william.qiu@starfivetech.com, davem@davemloft.net, linux-crypto@vger.kernel.org Subject: [PATCH AUTOSEL 6.7 11/19] crypto: starfive - Fix dev_err_probe return error Date: Mon, 15 Jan 2024 19:22:47 -0500 Message-ID: <20240116002311.214705-11-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002311.214705-1-sashal@kernel.org> References: <20240116002311.214705-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7 Content-Transfer-Encoding: 8bit From: Jia Jie Ho [ Upstream commit 8517c34e87025b3f74f3c07813d493828f369598 ] Current dev_err_probe will return 0 instead of proper error code if driver failed to get irq number. Fix the return code. Signed-off-by: Jia Jie Ho Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/starfive/jh7110-cryp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/starfive/jh7110-cryp.c b/drivers/crypto/starfive/jh7110-cryp.c index 08e974e0dd12..f6601f9d3aff 100644 --- a/drivers/crypto/starfive/jh7110-cryp.c +++ b/drivers/crypto/starfive/jh7110-cryp.c @@ -168,7 +168,7 @@ static int starfive_cryp_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, starfive_cryp_irq, 0, pdev->name, (void *)cryp); if (ret) - return dev_err_probe(&pdev->dev, irq, + return dev_err_probe(&pdev->dev, ret, "Failed to register interrupt handler\n"); clk_prepare_enable(cryp->hclk); -- 2.43.0