From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD10A56761; Tue, 16 Jan 2024 00:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QDNbTHQJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 616C9C433C7; Tue, 16 Jan 2024 00:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364823; bh=oMvl1NuqU/n3L8dT/FcVFvm6PLo9rE5CZ7rnIe1yzbk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QDNbTHQJBXVZbNYnoV/bw47rwATaDfWWGTb7dGUolh5ASJA7oS4PG3X6MMc0Yv+4S UKGp2ir8xxJA1lw4elJSiYXeAWP2144nccD11wdzj0oKWW7JS/2Z3D+xqGzvrEzrtB 6SuywmA8waypHn2kgCzKP/2p0gNGqNQ+afAQpWiUMZyKD7w41FNqAlgEUGK1Yx/9QS q+SBS0qoEQVV6qOIWXnAs3v/lq6mrH2OILhy72N5P6XrhLEVoHSOecfnaAcas81yzC /oTyzjXgzSXbDMDLjwLgOCeBJxpo/cirbok6mxw58lxn+ZgGd19Ku4BFZ+2LxERzPj 9hM+SxDH25s/w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Edward Adam Davis , syzbot+01cf2dbcbe2022454388@syzkaller.appspotmail.com, Dave Kleikamp , Sasha Levin , shaggy@kernel.org, brauner@kernel.org, jack@suse.cz, jfs-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.10 05/12] jfs: fix uaf in jfs_evict_inode Date: Mon, 15 Jan 2024 19:26:30 -0500 Message-ID: <20240116002649.216260-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002649.216260-1-sashal@kernel.org> References: <20240116002649.216260-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.208 Content-Transfer-Encoding: 8bit From: Edward Adam Davis [ Upstream commit e0e1958f4c365e380b17ccb35617345b31ef7bf3 ] When the execution of diMount(ipimap) fails, the object ipimap that has been released may be accessed in diFreeSpecial(). Asynchronous ipimap release occurs when rcu_core() calls jfs_free_node(). Therefore, when diMount(ipimap) fails, sbi->ipimap should not be initialized as ipimap. Reported-and-tested-by: syzbot+01cf2dbcbe2022454388@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_mount.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c index aa4ff7bcaff2..55702b31ab3c 100644 --- a/fs/jfs/jfs_mount.c +++ b/fs/jfs/jfs_mount.c @@ -172,15 +172,15 @@ int jfs_mount(struct super_block *sb) } jfs_info("jfs_mount: ipimap:0x%p", ipimap); - /* map further access of per fileset inodes by the fileset inode */ - sbi->ipimap = ipimap; - /* initialize fileset inode allocation map */ if ((rc = diMount(ipimap))) { jfs_err("jfs_mount: diMount failed w/rc = %d", rc); goto err_ipimap; } + /* map further access of per fileset inodes by the fileset inode */ + sbi->ipimap = ipimap; + return rc; /* -- 2.43.0