From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0DB461694; Tue, 16 Jan 2024 00:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QCWQvFak" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DF9BC433F1; Tue, 16 Jan 2024 00:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364913; bh=HdGfxXZ0XEKFo2ClUpfEyJbnDzm3dcJEo1mPRzM3HFk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QCWQvFakXE0IUQzynN+3Qws4KH6LyS+8T2waslx5POjwYODkhYiDTbAfAqCJSNT+U zp8Zwv3NkwQZsJOo+kdAYXixX7uULgXGFAGo1v/BwbZjq7QQa/DXj0WY6soly8X3yo jHj04WxNJCuI0QKvbtQqRrrybOVXu6/JJ7eMf5TFUuWVsyLMZoAfdHxHazD0eevoFO fjcH9EDus9sNyxRoJnklm0TDBvuWZfl4nOMHV3o3cVjF3P6QGOn4HsEZ0UKAEAyRMh E6MVXuBu3NVYx+chOvYl19511aR5rNcVJqwnUps3ktlrW2Hv97XsY4S4YEKavvPZbe iemBmVZcxF/3w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manas Ghandat , syzbot+411debe54d318eaed386@syzkaller.appspotmail.com, Dave Kleikamp , Sasha Levin , shaggy@kernel.org, juntong.deng@outlook.com, osmtendev@gmail.com, yogi.kernel@gmail.com, wonguk.lee1023@gmail.com, code@siddh.me, jfs-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.19 06/12] jfs: fix shift-out-of-bounds in dbJoin Date: Mon, 15 Jan 2024 19:27:59 -0500 Message-ID: <20240116002817.216837-6-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002817.216837-1-sashal@kernel.org> References: <20240116002817.216837-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.305 Content-Transfer-Encoding: 8bit From: Manas Ghandat [ Upstream commit cca974daeb6c43ea971f8ceff5a7080d7d49ee30 ] Currently while joining the leaf in a buddy system there is shift out of bound error in calculation of BUDSIZE. Added the required check to the BUDSIZE and fixed the documentation as well. Reported-by: syzbot+411debe54d318eaed386@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=411debe54d318eaed386 Signed-off-by: Manas Ghandat Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 893bc59658da..0cfdd52021f1 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -2840,7 +2840,9 @@ static int dbBackSplit(dmtree_t *tp, int leafno, bool is_ctl) * leafno - the number of the leaf to be updated. * newval - the new value for the leaf. * - * RETURN VALUES: none + * RETURN VALUES: + * 0 - success + * -EIO - i/o error */ static int dbJoin(dmtree_t *tp, int leafno, int newval, bool is_ctl) { @@ -2867,6 +2869,10 @@ static int dbJoin(dmtree_t *tp, int leafno, int newval, bool is_ctl) * get the buddy size (number of words covered) of * the new value. */ + + if ((newval - tp->dmt_budmin) > BUDMIN) + return -EIO; + budsz = BUDSIZE(newval, tp->dmt_budmin); /* try to join. -- 2.43.0