From: Johan Hovold <johan+linaro@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 5/7] ASoC: codecs: wcd9335: drop dead gain hacks
Date: Tue, 16 Jan 2024 10:39:01 +0100 [thread overview]
Message-ID: <20240116093903.19403-6-johan+linaro@kernel.org> (raw)
In-Reply-To: <20240116093903.19403-1-johan+linaro@kernel.org>
The vendor driver appears to be modifying the gain settings behind the
back of user space but these hacks never made it upstream except for
some essentially dead code that reads out the (cached) gain setting and
writes it back again on DAPM events.
Drop these incomplete and pointless hacks.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
sound/soc/codecs/wcd9335.c | 115 ++++++-------------------------------
1 file changed, 18 insertions(+), 97 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 43c648efd0d9..cee17b309160 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -3028,61 +3028,6 @@ static int wcd9335_codec_enable_slim(struct snd_soc_dapm_widget *w,
return 0;
}
-static int wcd9335_codec_enable_mix_path(struct snd_soc_dapm_widget *w,
- struct snd_kcontrol *kc, int event)
-{
- struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
- u16 gain_reg;
- int offset_val = 0;
- int val = 0;
-
- switch (w->reg) {
- case WCD9335_CDC_RX0_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX0_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX1_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX1_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX2_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX2_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX3_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX3_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX4_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX4_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX5_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX5_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX6_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX6_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX7_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX7_RX_VOL_MIX_CTL;
- break;
- case WCD9335_CDC_RX8_RX_PATH_MIX_CTL:
- gain_reg = WCD9335_CDC_RX8_RX_VOL_MIX_CTL;
- break;
- default:
- dev_err(comp->dev, "%s: No gain register avail for %s\n",
- __func__, w->name);
- return 0;
- }
-
- switch (event) {
- case SND_SOC_DAPM_POST_PMU:
- val = snd_soc_component_read(comp, gain_reg);
- val += offset_val;
- snd_soc_component_write(comp, gain_reg, val);
- break;
- case SND_SOC_DAPM_POST_PMD:
- break;
- }
-
- return 0;
-}
-
static u16 wcd9335_interp_get_primary_reg(u16 reg, u16 *ind)
{
u16 prim_int_reg = WCD9335_CDC_RX0_RX_PATH_CTL;
@@ -3291,38 +3236,26 @@ static int wcd9335_codec_enable_interpolator(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *kc, int event)
{
struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
- u16 gain_reg;
u16 reg;
- int val;
- int offset_val = 0;
if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT0 INTERP"))) {
reg = WCD9335_CDC_RX0_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX0_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT1 INTERP"))) {
reg = WCD9335_CDC_RX1_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX1_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT2 INTERP"))) {
reg = WCD9335_CDC_RX2_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX2_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT3 INTERP"))) {
reg = WCD9335_CDC_RX3_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX3_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT4 INTERP"))) {
reg = WCD9335_CDC_RX4_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX4_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT5 INTERP"))) {
reg = WCD9335_CDC_RX5_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX5_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT6 INTERP"))) {
reg = WCD9335_CDC_RX6_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX6_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT7 INTERP"))) {
reg = WCD9335_CDC_RX7_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX7_RX_VOL_CTL;
} else if (!(snd_soc_dapm_widget_name_cmp(w, "RX INT8 INTERP"))) {
reg = WCD9335_CDC_RX8_RX_PATH_CTL;
- gain_reg = WCD9335_CDC_RX8_RX_VOL_CTL;
} else {
dev_err(comp->dev, "%s: Interpolator reg not found\n",
__func__);
@@ -3336,9 +3269,6 @@ static int wcd9335_codec_enable_interpolator(struct snd_soc_dapm_widget *w,
break;
case SND_SOC_DAPM_POST_PMU:
wcd9335_config_compander(comp, w->shift, event);
- val = snd_soc_component_read(comp, gain_reg);
- val += offset_val;
- snd_soc_component_write(comp, gain_reg, val);
break;
case SND_SOC_DAPM_POST_PMD:
wcd9335_config_compander(comp, w->shift, event);
@@ -4367,33 +4297,24 @@ static const struct snd_soc_dapm_widget wcd9335_dapm_widgets[] = {
SND_SOC_DAPM_MIXER("SLIM RX5", SND_SOC_NOPM, 0, 0, NULL, 0),
SND_SOC_DAPM_MIXER("SLIM RX6", SND_SOC_NOPM, 0, 0, NULL, 0),
SND_SOC_DAPM_MIXER("SLIM RX7", SND_SOC_NOPM, 0, 0, NULL, 0),
- SND_SOC_DAPM_MUX_E("RX INT0_2 MUX", WCD9335_CDC_RX0_RX_PATH_MIX_CTL,
- 5, 0, &rx_int0_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT1_2 MUX", WCD9335_CDC_RX1_RX_PATH_MIX_CTL,
- 5, 0, &rx_int1_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT2_2 MUX", WCD9335_CDC_RX2_RX_PATH_MIX_CTL,
- 5, 0, &rx_int2_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT3_2 MUX", WCD9335_CDC_RX3_RX_PATH_MIX_CTL,
- 5, 0, &rx_int3_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT4_2 MUX", WCD9335_CDC_RX4_RX_PATH_MIX_CTL,
- 5, 0, &rx_int4_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT5_2 MUX", WCD9335_CDC_RX5_RX_PATH_MIX_CTL,
- 5, 0, &rx_int5_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT6_2 MUX", WCD9335_CDC_RX6_RX_PATH_MIX_CTL,
- 5, 0, &rx_int6_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT7_2 MUX", WCD9335_CDC_RX7_RX_PATH_MIX_CTL,
- 5, 0, &rx_int7_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
- SND_SOC_DAPM_MUX_E("RX INT8_2 MUX", WCD9335_CDC_RX8_RX_PATH_MIX_CTL,
- 5, 0, &rx_int8_2_mux, wcd9335_codec_enable_mix_path,
- SND_SOC_DAPM_POST_PMU),
+ SND_SOC_DAPM_MUX("RX INT0_2 MUX", WCD9335_CDC_RX0_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int0_2_mux),
+ SND_SOC_DAPM_MUX("RX INT1_2 MUX", WCD9335_CDC_RX1_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int1_2_mux),
+ SND_SOC_DAPM_MUX("RX INT2_2 MUX", WCD9335_CDC_RX2_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int2_2_mux),
+ SND_SOC_DAPM_MUX("RX INT3_2 MUX", WCD9335_CDC_RX3_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int3_2_mux),
+ SND_SOC_DAPM_MUX("RX INT4_2 MUX", WCD9335_CDC_RX4_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int4_2_mux),
+ SND_SOC_DAPM_MUX("RX INT5_2 MUX", WCD9335_CDC_RX5_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int5_2_mux),
+ SND_SOC_DAPM_MUX("RX INT6_2 MUX", WCD9335_CDC_RX6_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int6_2_mux),
+ SND_SOC_DAPM_MUX("RX INT7_2 MUX", WCD9335_CDC_RX7_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int7_2_mux),
+ SND_SOC_DAPM_MUX("RX INT8_2 MUX", WCD9335_CDC_RX8_RX_PATH_MIX_CTL,
+ 5, 0, &rx_int8_2_mux),
SND_SOC_DAPM_MUX("RX INT0_1 MIX1 INP0", SND_SOC_NOPM, 0, 0,
&rx_int0_1_mix_inp0_mux),
SND_SOC_DAPM_MUX("RX INT0_1 MIX1 INP1", SND_SOC_NOPM, 0, 0,
--
2.41.0
next prev parent reply other threads:[~2024-01-16 9:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 9:38 [PATCH 0/7] ASoC: qcom: volume fixes and codec cleanups Johan Hovold
2024-01-16 9:38 ` [PATCH 1/7] ASoC: qcom: sc8280xp: limit speaker volumes Johan Hovold
2024-01-16 11:11 ` Srinivas Kandagatla
2024-01-16 15:10 ` Mark Brown
2024-01-16 9:38 ` [PATCH 2/7] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Johan Hovold
2024-01-16 11:10 ` Srinivas Kandagatla
2024-01-16 13:10 ` Johan Hovold
2024-01-17 9:08 ` Johan Hovold
2024-01-16 9:38 ` [PATCH 3/7] ASoC: codecs: lpass-wsa-macro: drop dead mixer-path gain hack Johan Hovold
2024-01-16 9:39 ` [PATCH 4/7] ASoC: codecs: lpass-rx-macro: " Johan Hovold
2024-01-16 9:39 ` Johan Hovold [this message]
2024-01-16 9:39 ` [PATCH 6/7] ASoC: codecs: wcd934x: drop dead gain hacks Johan Hovold
2024-01-16 9:39 ` [PATCH 7/7] ASoC: codecs: msm8916-wcd-digital: " Johan Hovold
2024-01-16 12:33 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116093903.19403-6-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).