Re: [PATCH v5 23/23] Documentation: EM: Update with runtime modification design

Lukasz Luba
2023-12-20T07:56:15Z

On 12/20/23 02:08, Xuewen Yan wrote:
> On Tue, Dec 19, 2023 at 5:31 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>>
>>
>>
>> On 12/19/23 06:22, Xuewen Yan wrote:
>>> Hi Lukasz,
>>>
>>> On Wed, Nov 29, 2023 at 7:11 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>>
>> [snip]
>>
>>>> +
>>>> + -> drivers/soc/example/example_em_mod.c
>>>> +
>>>> + 01 static void foo_get_new_em(struct device *dev)
>>>
>>> Because now some drivers use the dev_pm_opp_of_register_em() to
>>> register energy model,
>>> and maybe we can add a new function to update the energy model using
>>> "EM_SET_ACTIVE_POWER_CB(em_cb, cb)"
>>> instead of letting users set power again?
>>>
>>
>> There are different usage of this EM feature:
>> 1. Adjust power values after boot is finish and e.g. ASV in Exynos
>> has adjusted new voltage values in the OPP framework. It's
>> due to chip binning. I have described that in conversation
>> below patch 22/23. I'm going to send a patch for that
>> platform and OPP fwk later as a follow up to this series.
>
> I understand what you mean, what I mean is that if we can provide an
> interface for changing EM of opp fwk, it will be more friendly for
> those users who use opp, because then they don't have to calculate the
> new EM by themselves, but only need After updating the voltage of opp,
> just call this interface directly.

It is the plan. Don't worry. I didn't wanted to push this in one
big patch set. Exynos driver + the OPP change would do exactly this.
The EM functions from drivers/opp/of.c will be re-used for this.

It is too big to be made in one step. There is pattern in those more
complex changes, like in Arm SCMI fwk to make the improvements
gradually. This folds into the same bucket.

Although, you are another person asking for similar thing, so I
will send a follow-up change using this new EM API - instead
of waiting to finish this review.

Thanks,
Lukasz