Re: [PATCH v5 05/23] PM: EM: Refactor a new function em_compute_costs()

Qais Yousef
2023-12-28T17:14:43Z

On 12/19/23 10:59, Lukasz Luba wrote:
>
>
> On 12/17/23 17:58, Qais Yousef wrote:
> > On 11/29/23 11:08, Lukasz Luba wrote:
> > > Refactor a dedicated function which will be easier to maintain and re-use
> > > in future. The upcoming changes for the modifiable EM perf_state table
> > > will use it (instead of duplicating the code).
> >
> > nit: What is being refactored? Looks like you took em_compute_cost() out of
> > em_create_perf_table().
>
> Yes, it's going to be re-used later for also update code path, not only
> register code path.

Sorry I was terse. I meant the commit message could be clearer to require less
effort untangling what is actually being changed.