From: Erico Nunes <nunes.erico@gmail.com>
To: Qiang Yu <yuq825@gmail.com>,
dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org
Cc: anarsoul@gmail.com,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Sumit Semwal <sumit.semwal@linaro.org>,
christian.koenig@amd.com, linux-kernel@vger.kernel.org,
Erico Nunes <nunes.erico@gmail.com>
Subject: [PATCH v1 6/6] drm/lima: improve some pp debug messages
Date: Wed, 17 Jan 2024 04:12:12 +0100 [thread overview]
Message-ID: <20240117031212.1104034-7-nunes.erico@gmail.com> (raw)
In-Reply-To: <20240117031212.1104034-1-nunes.erico@gmail.com>
Make the messages more consistent by showing the pp name.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
drivers/gpu/drm/lima/lima_pp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c
index ac097dd75072..d9e178d6645d 100644
--- a/drivers/gpu/drm/lima/lima_pp.c
+++ b/drivers/gpu/drm/lima/lima_pp.c
@@ -197,7 +197,7 @@ static int lima_pp_hard_reset(struct lima_ip *ip)
pp_write(LIMA_PP_CTRL, LIMA_PP_CTRL_FORCE_RESET);
ret = lima_poll_timeout(ip, lima_pp_hard_reset_poll, 10, 100);
if (ret) {
- dev_err(dev->dev, "pp hard reset timeout\n");
+ dev_err(dev->dev, "pp %s hard reset timeout\n", lima_ip_name(ip));
return ret;
}
@@ -423,8 +423,8 @@ static void lima_pp_task_error(struct lima_sched_pipe *pipe)
for (i = 0; i < pipe->num_processor; i++) {
struct lima_ip *ip = pipe->processor[i];
- dev_err(ip->dev->dev, "pp task error %d int_state=%x status=%x\n",
- i, pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));
+ dev_err(ip->dev->dev, "pp %s task error int_state=%x status=%x\n",
+ lima_ip_name(ip), pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));
lima_pp_hard_reset(ip);
}
--
2.43.0
next prev parent reply other threads:[~2024-01-17 3:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 3:12 [PATCH v1 0/6] drm/lima: fixes and improvements to error recovery Erico Nunes
2024-01-17 3:12 ` [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts Erico Nunes
2024-01-17 18:13 ` Vasily Khoruzhick
2024-01-18 1:36 ` Qiang Yu
2024-01-18 11:14 ` Erico Nunes
2024-01-19 1:50 ` Qiang Yu
2024-01-23 23:19 ` Erico Nunes
2024-01-24 1:03 ` Qiang Yu
2024-01-17 3:12 ` [PATCH v1 2/6] drm/lima: reset async_reset on pp hard reset Erico Nunes
2024-01-17 18:17 ` Vasily Khoruzhick
2024-01-18 1:56 ` Qiang Yu
2024-01-17 3:12 ` [PATCH v1 3/6] drm/lima: set bus_stop bit before " Erico Nunes
2024-01-17 18:23 ` Vasily Khoruzhick
2024-01-18 2:01 ` Qiang Yu
2024-01-18 11:43 ` Erico Nunes
2024-01-17 3:12 ` [PATCH v1 4/6] drm/lima: handle spurious timeouts due to high irq latency Erico Nunes
2024-01-17 18:26 ` Vasily Khoruzhick
2024-01-18 2:46 ` Qiang Yu
2024-01-18 11:38 ` Erico Nunes
2024-01-19 1:43 ` Qiang Yu
2024-01-21 3:04 ` Qiang Yu
2024-01-21 9:56 ` Hillf Danton
2024-01-21 11:20 ` Qiang Yu
2024-01-21 15:11 ` Erico Nunes
2024-01-23 1:18 ` Qiang Yu
2024-01-17 3:12 ` [PATCH v1 5/6] drm/lima: remove guilty drm_sched context handling Erico Nunes
2024-01-17 18:28 ` Vasily Khoruzhick
2024-01-17 3:12 ` Erico Nunes [this message]
2024-01-17 18:29 ` [PATCH v1 6/6] drm/lima: improve some pp debug messages Vasily Khoruzhick
2024-01-17 7:22 ` [PATCH v1 0/6] drm/lima: fixes and improvements to error recovery Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117031212.1104034-7-nunes.erico@gmail.com \
--to=nunes.erico@gmail.com \
--cc=airlied@gmail.com \
--cc=anarsoul@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lima@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox