Re: [PATCH 15/45] tty: vt: pass vpar as unsigned to csi_J() and csi_K()

Jiri Slaby
2024-01-19T06:29:06Z

On 18. 01. 24, 8:57, Jiri Slaby (SUSE) wrote:
> vc_data::vc_par is passed to these function and that is unsigned. So
> accept unsigned in csi_J() and csi_K().

I've just found out the parameters can be removed completely (v2
approaching next week).

> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> drivers/tty/vt/vt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index c00c568c11a5..4b514187ef15 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1505,7 +1505,7 @@ enum {
> CSI_J_FULL = 3,
> };
>
> -static void csi_J(struct vc_data *vc, int vpar)
> +static void csi_J(struct vc_data *vc, unsigned int vpar)
> {
> unsigned short *start;
> unsigned int count;
> @@ -1548,7 +1548,7 @@ enum {
> CSI_K_LINE = 2,
> };
>
> -static void csi_K(struct vc_data *vc, int vpar)
> +static void csi_K(struct vc_data *vc, unsigned int vpar)
> {
> unsigned int count;
> unsigned short *start = (unsigned short *)vc->vc_pos;

--
js
suse labs