Re: [PATCH 3/3] selftests/net: Clean-up double assignment

Simon Horman
2024-01-19T16:25:30Z

On Thu, Jan 18, 2024 at 02:51:36AM +0000, Dmitry Safonov wrote:
> Yeah, copy'n'paste typo.
>
> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test")
> Reported-by: Nassiri, Mohammad <mnassiri@ciena.com>
> Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@DM6PR04MB4202.namprd04.prod.outlook.com/
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---

Hi Dmitry,

This seems more like a clean-up than a fix.

> tools/testing/selftests/net/tcp_ao/lib/sock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/tcp_ao/lib/sock.c b/tools/testing/selftests/net/tcp_ao/lib/sock.c
> index c75d82885a2e..923a9bb4f1ca 100644
> --- a/tools/testing/selftests/net/tcp_ao/lib/sock.c
> +++ b/tools/testing/selftests/net/tcp_ao/lib/sock.c
> @@ -377,7 +377,6 @@ int test_get_tcp_ao_counters(int sk, struct tcp_ao_counters *out)
>
> key_dump[0].nkeys = nr_keys;
> key_dump[0].get_all = 1;
> - key_dump[0].get_all = 1;
> err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS,
> key_dump, &key_dump_sz);
> if (err) {
>
> --
> 2.43.0
>