Re: [PATCH v11 1/2] dt-bindings: adc: add AD7173

Ceclan Dumitru
2024-01-08T09:11:45Z

On 12/21/23 19:45, Krzysztof Kozlowski wrote:
> On 20/12/2023 11:48, Dumitru Ceclan wrote:
>> The AD7173 family offer a complete integrated Sigma-Delta ADC solution
>> which can be used in high precision, low noise single channel applications
>> or higher speed multiplexed applications. The Sigma-Delta ADC is intended
>> primarily for measurement of signals close to DC but also delivers
>> outstanding performance with input bandwidths out to ~10kHz.
>>
>> Signed-off-by: Dumitru Ceclan <mitrutzceclan@gmail.com>
>> ---
>> V10->V11
>> - Fix example warning: '#gpio-cells' is a dependency of 'gpio-controller'
>> - Add description to #gpio-cells property
>> V9->V10
>
> None of your previous version were tested before sending, so I have
> really doubts that this version was.
>
>> - Fix dt_binding_check type warning from adi,reference-select
>> V8->v9
>
> ...
>
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +# Copyright 2023 Analog Devices Inc.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7173.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Analog Devices AD7173 ADC
>> +
>> +maintainers:
>> + - Ceclan Dumitru <dumitru.ceclan@analog.com>
>> +
>> +description: |
>> + Bindings for the Analog Devices AD717X ADC's. Datasheets for supported chips:
>
> If there is going to be resend:
> Drop "Bindings for" and instead describe shortly the hardware. Also wrap
> above according to Linux coding style, so at 80.
>
>> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7172-2.pdf
>> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7173-8.pdf
>> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7175-2.pdf
>> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7176-2.pdf
>> +
>
> Rest looks good, so please tell did you test it?

Yes.