From: Johan Hovold <johan+linaro@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
stable@vger.kernel.org
Subject: [PATCH v3 2/5] ASoC: codecs: wsa883x: lower default PA gain
Date: Thu, 18 Jan 2024 17:58:08 +0100 [thread overview]
Message-ID: <20240118165811.13672-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20240118165811.13672-1-johan+linaro@kernel.org>
The default PA gain is set to a pretty high level of 15 dB. Initialise
the register to the minimum -3 dB level instead.
This is specifically needed to allow machine drivers to use the lowest
level as a volume limit.
Cc: stable@vger.kernel.org # 6.5
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
sound/soc/codecs/wsa883x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
index 32983ca9afba..8942c88dee09 100644
--- a/sound/soc/codecs/wsa883x.c
+++ b/sound/soc/codecs/wsa883x.c
@@ -722,7 +722,7 @@ static struct reg_default wsa883x_defaults[] = {
{ WSA883X_WAVG_PER_6_7, 0x88 },
{ WSA883X_WAVG_STA, 0x00 },
{ WSA883X_DRE_CTL_0, 0x70 },
- { WSA883X_DRE_CTL_1, 0x08 },
+ { WSA883X_DRE_CTL_1, 0x1e },
{ WSA883X_DRE_IDLE_DET_CTL, 0x1F },
{ WSA883X_CLSH_CTL_0, 0x37 },
{ WSA883X_CLSH_CTL_1, 0x81 },
--
2.41.0
next prev parent reply other threads:[~2024-01-18 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 16:58 [PATCH v3 0/5] ASoC: qcom: volume fixes and codec cleanups Johan Hovold
2024-01-18 16:58 ` [PATCH v3 1/5] ASoC: codecs: wsa883x: fix PA volume control Johan Hovold
2024-01-18 17:24 ` Mark Brown
2024-01-19 7:34 ` Johan Hovold
2024-01-19 7:14 ` Srinivas Kandagatla
2024-01-19 7:49 ` Johan Hovold
2024-01-18 16:58 ` Johan Hovold [this message]
2024-01-18 17:21 ` [PATCH v3 2/5] ASoC: codecs: wsa883x: lower default PA gain Mark Brown
2024-01-19 7:57 ` Johan Hovold
2024-01-19 7:15 ` Srinivas Kandagatla
2024-01-19 8:00 ` Johan Hovold
2024-01-18 16:58 ` [PATCH v3 3/5] ASoC: qcom: sc8280xp: limit speaker volumes Johan Hovold
2024-01-19 7:37 ` Srinivas Kandagatla
2024-01-19 8:06 ` Johan Hovold
2024-01-18 16:58 ` [PATCH v3 4/5] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Johan Hovold
2024-01-19 7:45 ` Srinivas Kandagatla
2024-01-19 8:10 ` Johan Hovold
2024-01-18 16:58 ` [PATCH v3 5/5] ASoC: codecs: wcd9335: drop unused gain hack remnant Johan Hovold
2024-01-19 7:46 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118165811.13672-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox