Re: [PATCH v7 1/4] dt-bindings: touchscreen: add touch-overlay property

Conor Dooley
2024-03-19T17:06:53Z

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

On Tue, Mar 19, 2024 at 12:13:08PM +0100, Javier Carrasco wrote:
> On 1/19/24 08:43, Javier Carrasco wrote:
> > The touch-overlay encompasses a number of touch areas that define a
> > clipped touchscreen area and/or buttons with a specific functionality.
> >
> > A clipped touchscreen area avoids getting events from regions that are
> > physically hidden by overlay frames.
> >
> > For touchscreens with printed overlay buttons, sub-nodes with a suitable
> > key code can be defined to report key events instead of the original
> > touch events.
> >
> > Reviewed-by: Jeff LaBundy <jeff@labundy.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
> > ---
> > .../bindings/input/touchscreen/touchscreen.yaml | 119 +++++++++++++++++++++
> > 1 file changed, 119 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
> > index 431c13335c40..eb1e86fa86c6 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
> > @@ -87,6 +87,125 @@ properties:
> > touchscreen-y-plate-ohms:
> > description: Resistance of the Y-plate in Ohms
> >
> > + touch-overlay:
>
> Even though it has already been reviewed, just in case before it gets
> applied. Should it not be:
>
> description: |
> List of nodes...
>
> instead, to keep formatting?

Yes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]