From: Florian Westphal <fw@strlen.de>
To: wangkeqi <wangkeqi_chris@163.com>
Cc: Florian Westphal <fw@strlen.de>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
wangkeqi <wangkeqiwang@didiglobal.com>,
kernel test robot <oliver.sang@intel.com>,
fengwei.yin@intel.com
Subject: Re: Re: [PATCH net v2] connector: Change the judgment conditions for clearing proc_event_num_listeners
Date: Fri, 19 Jan 2024 13:37:05 +0100 [thread overview]
Message-ID: <20240119123705.GB9015@breakpoint.cc> (raw)
In-Reply-To: <1adb8c68.a950.18d1d237182.Coremail.wangkeqi_chris@163.com>
wangkeqi <wangkeqi_chris@163.com> wrote:
>
> If cn_netlink_has_listeners() is used instead of proc_event_num_listeners, I think proc_event_num_listeners will be completely meaningless.
> I read the code and found that there is nothing wrong with cn_netlink_has_listeners as a judgment of whether to send msg.
> sock_close will update the listeners. The previous proc_event_num_listeners count was wrong, making it meaningless.
> But if I change it to cn_netlink_has_listeners, will it affect some low-probability scenarios?
Please avoid top-posting on netdev mailing list.
Yes, thats what I meant, replace proc_event_num_listeners.
I do not know what a 'low-probability scenarios' is.
prev parent reply other threads:[~2024-01-19 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 1:57 [PATCH net v2] connector: Change the judgment conditions for clearing proc_event_num_listeners wangkeqi
2024-01-17 11:47 ` Florian Westphal
2024-01-18 15:14 ` wangkeqi
2024-01-19 12:37 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119123705.GB9015@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fengwei.yin@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
--cc=wangkeqi_chris@163.com \
--cc=wangkeqiwang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox