From: Suresh Kumar <suresh2514@gmail.com>
To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Suresh Kumar <suresh2514@gmail.com>
Subject: [PATCH] i40e: print correct hw max rss count in kernel ring buffer
Date: Fri, 19 Jan 2024 18:46:52 +0530 [thread overview]
Message-ID: <20240119131652.8050-1-suresh2514@gmail.com> (raw)
The value printed for "HW max RSS count" is wrong in kernel dmesg for i40e
NICs:
... i40e 0000:63:00.0: User requested queue count/HW max RSS count: 48/64
whereas ethtool reports the correct value from "vsi->num_queue_pairs"
Channel parameters for eno33:
Pre-set maximums:
RX: n/a
TX: n/a
Other: 1
Combined: 96
Current hardware settings:
RX: n/a
TX: n/a
Other: 1
Combined: 96 <-------
and is misleading.
This value is printed from 'pf->rss_size_max' which seems hardcoded.
Below commit also removed this 64 limit:
Commit e56afa599609d3afe8b0ce24b553ab95e9782502
Author: Amritha Nambiar <amritha.nambiar@intel.com>
Date: Wed Nov 8 16:38:43 2017 -0800
i40e: Remove limit of 64 max queues per channel
Signed-off-by: Suresh Kumar <suresh2514@gmail.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index d5519af34657..f5c1ec190f7e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count)
i40e_pf_config_rss(pf);
}
dev_info(&pf->pdev->dev, "User requested queue count/HW max RSS count: %d/%d\n",
- vsi->req_queue_pairs, pf->rss_size_max);
+ vsi->req_queue_pairs, vsi->num_queue_pairs);
return pf->alloc_rss_size;
}
--
2.43.0
next reply other threads:[~2024-01-19 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 13:16 Suresh Kumar [this message]
2024-01-19 14:49 ` [PATCH] i40e: print correct hw max rss count in kernel ring buffer Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119131652.8050-1-suresh2514@gmail.com \
--to=suresh2514@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox